lint: fix typing issues with updated pyright
Metadata
Current evaluation
Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main after resolving linting errors caused by an updated pyright version. The maintainer fixed type annotations, achieving 100% diff coverage and a 0.03% overall coverage increase upon successful integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #186 style(typing): update pyright | craft-application | merged | Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions. | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions. | |
| #4485 style(lint): fix pyright errors | snapcraft | merged | Merged after approval by three reviewers. Resolved pyright linting errors across nine files (+59/-38 lines). Codecov confirmed test coverage remained stable at 89.2%. | |
| #158 style(types): update pyright | craft-store | merged | Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards. | |
| #237 style: fix pyright config | craft-cli | merged | Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated. | |
| #177 linting: address pyright issues | craft-parts | merged | Merged following approval and passing CI. Updated type declarations to comply with Pyright 1.1.225 by adding Optional to None arguments and correcting callback type typos across 16 files. | |
| #4205 lint: fix for pyright 1.1.312 | snapcraft | merged | Merged a fix for type errors in account.py triggered by Pyright 1.1.312's stricter kwargs validation. The change corrects type annotations, passes CI, and was approved by a reviewer. | |
| #1525 build: enable pyright | charmcraft | merged | Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff. | |
| #4080 lint: initialize retcode to satisfy pyright | snapcraft | merged | Merged a minor lint fix initializing the retcode variable to 1 to satisfy pyright type checking. The harmless change was approved, passed CI with 100% diff coverage, and merged into main. | |
| #701 build(deps): update pyright to 1.1.358 | craft-parts | merged | Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments. |