← Back to issue list

lint: fix typing issues with updated pyright

View original Github issue

Metadata

Project
craft-archives
Number
#58
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.

Resolution: closed resolved

Reason: PR #58 was merged into main as commit 7983916, resolving the lint failures caused by the updated Pyright version.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
stealth/space-bunny-alpha — closed resolved PR #58 by maintainer lengau was approved and merged as commit 7983916, fixing pyright typing errors across 7 files (+28/-19) after a pyright upgrade; Codecov reported +0.03% coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated; coverage increased by 0.03%.
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#186 style(typing): update pyright craft-application merged Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
84%
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
80%
#4485 style(lint): fix pyright errors snapcraft merged Merged PR #4485, fixing Pyright lint errors across nine files with three reviewer approvals.
79%
#158 style(types): update pyright craft-store merged Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.
79%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.
77%
#4205 lint: fix for pyright 1.1.312 snapcraft merged Merged #4205 (commit 6b94548db), fixing login argument typing for Pyright 1.1.312 so lint passes.
77%
#65 Fixed new pyright issues. craft-cli merged Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479).
77%
#639 style: update pyright craft-parts merged Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files.
77%
#1528 Enable pyright and clear the typing issues charmcraft closed Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
76%
#237 style: fix pyright config craft-cli merged Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
75%