← Back to issue list

extensions: add cli commands

View original Github issue

Metadata

Project
rockcraft
Number
#292
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #292 (commit e8858077) added `list-extensions` and `expand-extensions` CLI commands with Snapcraft-equivalent semantics, plus test-data refactoring; closed rockcraft#274.

Resolution: closed resolved

Reason: The PR was approved by two reviewers and merged into main as commit e8858077 ('extensions: add cli commands (#292)'), implementing the `list-extensions` and `expand-extensions` commands. Its body states 'Fixes #274', and rockcraft#274 'Support Extensions CLI' was closed accordingly.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The commands are 'list-extensions' and 'expand-extensions' and they have the same semantics as the Snapcraft equivalents. Some minor refactoring to re-use testing data accross multiple tests. Fixes #274 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #292 (commit e8858077) added `list-extensions` and `expand-extensions` CLI commands with Snapcraft-equivalent semantics, plus test-data refactoring; closed rockcraft#274.
stealth/space-bunny-alpha — closed resolved Merged rockcraft#292, adding list-extensions and expand-extensions with Snapcraft-equivalent semantics and shared test-data refactoring; fixes rockcraft#274.
qwen/qwen3.6-35b-a3b — — Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, with minor test refactoring. Resolves issue #274.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/rockcraft#274 (confidence 95%)

    Issue #274 'Support Extensions CLI' is the tracking issue fixed by this PR and was closed by it.

  • Superseded By: canonical/rockcraft#856 (confidence 55%)

    Much later, PR #856 ('refactor: use craft-application 5') replaced Rockcraft's own command implementations in rockcraft/commands/extensions.py with upstream craft-application commands carrying the same names.

Related issues

Issue Project State Summary Similarity
#274 Support Extensions CLI rockcraft closed list-extensions and expand-extensions shipped via merged PR #292, commit e8858077, adding rockcraft/commands/extensions.py plus a hidden `extensions` alias; follow-ups fixed validation-error reporting.
80%
#2237 cli: add list-extensions command snapcraft merged Merged in snapcraft#2237 via commit 9a6c7ed3a, adding list-extensions and bash completion; resolves LP #1788639.
76%
#1103 fix: remove snapcraft.yaml reference from expand-extensions rockcraft open Two-line help/docstring fix in rockcraft/commands/extensions.py replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions. Approved, CI passing, no unresolved comments; verified still applicable to current main.
75%
#1268 feat(extensions): add cli commands charmcraft merged Merged PR #1268 via dfe86563, adding expand-extensions and list-extensions commands and resolving extension CLI support in #1242.
75%
#3679 Expand extensions snapcraft merged Merged PR snapcore/snapcraft#3679 via commit 07a8d695c, expanding extensions for CRAFT-948 in the snapcraft/7.0 branch.
74%
#3678 commands: list-extensions and extensions alias snapcraft merged Merged PR #3678 (commit 39d42857d, merge 23c327e82) into snapcraft/7.0 adding an `extensions` command listing new-codebase extensions merged with legacy ones, with `list-extensions` kept as an alias via inheritance. Later renamed and removed.
73%
#3197 experimental extension support snapcraft merged Merged PR #3197 (commit be00472e5) added experimental extension support to snapcraft, landed after its prerequisite PR #3196 (c1a41fd84) which unset false boolean CLI flags.
73%
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows 'expand-extensions: Expand extensions in snapcraft.yaml', a copy-paste leftover; rockcraft.yaml is the correct file. Still present at HEAD; fixes #885/#1103 approved but unmerged.
73%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing.
72%
#2706 extensions: improve docsting (used in the cli) snapcraft merged Merged PR #2706 in commit 91a4b4036, improving the gnome-3-28 extension description and its `snapcraft extension` CLI help.
72%