← Back to issue list

fix: remove snapcraft.yaml reference from expand-extensions

View original Github issue

Metadata

Project
rockcraft
Number
#1103
Type
pull request
State
open
Author
gcomneno
Labels
—
Created
Updated
Closed
—

Current evaluation

Two-line help/docstring fix in rockcraft/commands/extensions.py replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions. Approved, CI passing, no unresolved comments; verified still applicable to current main.

Suggested action: needs review

Reason: Verified at pinned HEAD that rockcraft/commands/extensions.py:85 (docstring) and :88 (help_msg = "Expand extensions in snapcraft.yaml") still contain the stale reference, so the 3-line change still applies cleanly; the PR is marked approved with 0 unresolved review comments and only the labeler check passing with none failing. Three sibling PRs (#1111, #1117, #1210) were closed explicitly as duplicates of this one, confirming #1103 is the canonical fix — it only needs a maintainer to merge it, though it has sat 45 days without activity.

Evaluated by: mr-cal-bot

Impact: 12 Quick Win: 9 Complexity: 5 Confidence: 90 Actionability: 82

Issue body

Remove remaining references to snapcraft.yaml in the expand-extensions command help and docstring. Fixes #885.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 12
Quick Win: 9
Complexity: 5
Confidence: 90
Actionability: 82
needs review Two-line help/docstring fix in rockcraft/commands/extensions.py replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions. Approved, CI passing, no unresolved comments; verified still applicable to current main.
stealth/space-bunny-alpha
Impact: 15
Quick Win: 13
Complexity: 3
Confidence: 97
Actionability: 92
needs review Updates two expand-extensions help/docstring occurrences from snapcraft.yaml to rockcraft.yaml for #885. Approved, mergeable, and all reported checks pass; awaiting maintainer merge.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 90
Actionability: 80
needs review Removes snapcraft.yaml references from expand-extensions help text and docstring in rockcraft/commands/extensions.py. Approved, CI passing, awaiting maintainer merge.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 55
Complexity: 5
Confidence: 80
needs review Removes snapcraft.yaml references from expand-extensions help text and docstring (3 lines, 1 file). Approved with CI green, but inactive ~6 months; fix still unapplied in codebase; likely duplicate of older PR #885.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 5
Confidence: 90
needs review Removes outdated snapcraft.yaml references from expand-extensions command help and docstring. Approved by one reviewer, CI passing, awaiting maintainer merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 5
Confidence: 75
needs review Updates help text and docstring for expand-extensions command to remove outdated snapcraft.yaml references. Unreviewed and inactive for 4 months.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 5
Confidence: 75
needs review Removes outdated snapcraft.yaml references from expand-extensions command help and docstring. The PR is currently inactive with no maintainer comments or CI feedback.

Update history

Date Change
updated

Related work

  • Duplicate Of: canonical/rockcraft#1111 (confidence 95%)

    Closed unmerged as a duplicate of #1103, confirming this PR is the accepted version.

  • Duplicate Of: canonical/rockcraft#1210 (confidence 92%)

    Closed unmerged as a duplicate of approved, CI-passing #1103.

  • Related To: canonical/rockcraft#885 (confidence 90%)

    The issue this PR targets (#885 is itself still an open PR with the same goal), so the 'Fixes #885' reference is technically mis-targeted and that PR remains open.

  • Duplicate Of: canonical/rockcraft#1117 (confidence 90%)

    Closed unmerged after its author redirected the same fix to #1103/#1110.

  • Related To: rockcraft#658 (confidence 88%)

    Open issue describing the identical help-text bug in expand-extensions; this change would resolve it.

Related issues

Issue Project State Summary Similarity
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows 'expand-extensions: Expand extensions in snapcraft.yaml', a copy-paste leftover; rockcraft.yaml is the correct file. Still present at HEAD; fixes #885/#1103 approved but unmerged.
84%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing.
83%
#885 fix: Removed reference to snapcraft.yaml in expand extensions rockcraft open Removes a snapcraft.yaml reference from expand-extensions help text (1 line, fixes #658). Approved, CI green, but untouched for 212 days and superseded by newer approved PR #1103, which makes the same correction more completely.
81%
#1117 fix(cli): refer to rockcraft.yaml in expand-extensions help rockcraft closed Docs-only PR correcting the expand-extensions help text to say rockcraft.yaml. Closed unmerged by the author after maintainer @asanvaq noted it duplicated the work in #1103 and #1110; fix still pending in #1103.
79%
#1111 Fix expand-extensions help text to reference rockcraft.yaml rockcraft closed Closed unmerged as a duplicate of #1103, which included the same rockcraft.yaml help-text correction and additional overview wording fixes.
76%
#292 extensions: add cli commands rockcraft merged Merged PR #292 (commit e8858077) added `list-extensions` and `expand-extensions` CLI commands with Snapcraft-equivalent semantics, plus test-data refactoring; closed rockcraft#274.
75%
#1057 fix(schema): allow extensions field in rockcraft.yaml rockcraft merged Merged as commit 23fe7dfe, adding the extensions field to the rockcraft.yaml schema and fixing IDE validation reported in canonical/rockcraft#922.
72%
#351 ExtensionError link to non-exists URL rockcraft open Maintainer-reported broken docs URL ("https://rockcraft.io/docs/supported-extensions") in ExtensionError plus a "snapcraft.yaml" naming slip in the Extension docstring. URL already fixed by PR #777; wording nit still present.
72%
#1033 docs: revise issue templates rockcraft merged Merged PR #1033 revised Rockcraft’s GitHub issue templates using reviewed Snapcraft content; all CI checks passed.
72%
#15 feat: add Snapcraft 8.x rock snapcraft-rocks merged Merged canonical/snapcraft-rocks#15, adding a Snapcraft 8.x rock through a one-line change after approval by two reviewers.
71%