← Back to issue list

fix: remove snapcraft.yaml reference from expand-extensions

View original Github issue

Metadata

Project
rockcraft
Number
#1103
Type
pull request
State
open
Author
gcomneno
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes snapcraft.yaml references from expand-extensions help text and docstring (3 lines, 1 file). Approved with CI green, but inactive ~6 months; fix still unapplied in codebase; likely duplicate of older PR #885.

Suggested action: needs review

Reason: The PR is approved with all CI checks passing, and I verified the target strings (lines 85 and 88 of rockcraft/commands/extensions.py) still exist at HEAD, so the fix remains applicable and ready to land. However, the PR body says 'Fixes #885' while #885 is itself an approved PR making the identical change, so a maintainer should decide whether to land this one or the older #885 rather than auto-merging.

Impact: 10 Quick Win: 9.5 Staleness: 55 Complexity: 5 Confidence: 80

Issue body

Remove remaining references to snapcraft.yaml in the expand-extensions command help and docstring. Fixes #885.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 10
Quick Win: 9.5
Staleness: 55
Complexity: 5
Confidence: 80
needs review Removes snapcraft.yaml references from expand-extensions help text and docstring (3 lines, 1 file). Approved with CI green, but inactive ~6 months; fix still unapplied in codebase; likely duplicate of older PR #885.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 5
Confidence: 90
needs review Removes outdated snapcraft.yaml references from expand-extensions command help and docstring. Approved by one reviewer, CI passing, awaiting maintainer merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 5
Confidence: 75
needs review Updates help text and docstring for expand-extensions command to remove outdated snapcraft.yaml references. Unreviewed and inactive for 4 months.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 5
Confidence: 75
needs review Removes outdated snapcraft.yaml references from expand-extensions command help and docstring. The PR is currently inactive with no maintainer comments or CI feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 10
Confidence: 85
needs review Removes outdated snapcraft.yaml references from expand-extensions command help and docstring. Fixes #885. Open pull request with no comments or labels, last updated 100 days ago. Awaiting review and merge.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#658 (confidence 85%)

    Underlying issue: 'Help includes expand-extensions entry with reference to snapcraft.yaml'; this PR's change directly addresses it.

  • Duplicate Of: rockcraft#885 (confidence 80%)

    PR body says 'Fixes #885', but #885 is itself a PR removing the same snapcraft.yaml reference, already approved and awaiting merge for 14+ months.

Related issues

Issue Project State Summary Similarity
#885 fix: Removed reference to snapcraft.yaml in expand extensions rockcraft open One-line fix removing the snapcraft.yaml reference from the expand-extensions help text and docstring, fixing #658. Approved by 2 reviewers with all CI checks green, but unmerged and inactive ~6 months; the fix is still unapplied in the codebase.
94%
#4110 extensions: parse snapcraft.yaml before expanding extensions snapcraft merged Merged fix for the expand-extensions command to parse snapcraft.yaml before expanding extensions. Resolves core22 parsing issues with parse-info and advanced grammar keywords. Approved, passed CI, and merged into main.
76%
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows expand-extensions referencing snapcraft.yaml instead of rockcraft.yaml. Bug still present in code; two approved but unmerged PRs (#885, #1103) fix the help text. Labeled good first issue, no maintainer activity since 2024.
75%
#3679 Expand extensions snapcraft merged Merged into snapcraft/7.0 after approval and passing CI checks. The changes expand extensions, address CRAFT-948, and increased overall coverage by 0.17%.
73%
#292 extensions: add cli commands rockcraft merged Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines).
72%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed Closed as a duplicate of PR #1103, which already implements the same help text fix and is approved. The change to reference rockcraft.yaml instead of snapcraft.yaml in the expand-extensions command is handled by the superseding pull request.
72%
#2348 extensions: remove root extensions snapcraft merged Merged removal of root extension declarations from snapcraft.yaml. Resolves LP #1797631 by deferring application scope decisions until usage patterns clarify. Approved by maintainer, passed CI, and modified two files.
72%
#2011719 snapcraft expand-extensions is broken snapcraft (launchpad) open snapcraft expand-extensions command produces invalid YAML with parse-info field error. Issue is ~3.5 years old with no activity.
71%
#5924 docs: clean up 'snapcraft.yaml' snapcraft merged Merged documentation cleanup for snapcraft.yaml, including typo fixes, docstring link updates, and JSON schema regeneration. Reviewers approved the non-functional changes, and the schema workflow was resolved by running make schema.
71%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
71%