refactor: use craft-application 5
Metadata
Current evaluation
Merged as commit 2139bcd2: refactored Rockcraft onto craft-application 5 (49 files, +959/-915) after approval from 3 reviewers; later bumped to craft-application 6.0 via #1027.
Resolution: closed resolved
Reason: The pull request itself was merged into main as commit 2139bcd2 ("refactor: use craft-application 5 (#856)"), completing the craft-application 5 migration across 49 files. Later dependency PRs #1027 (6.0) and #1029 (6.0.1) built on top of this refactor.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2139bcd2: refactored Rockcraft onto craft-application 5 (49 files, +959/-915) after approval from 3 reviewers; later bumped to craft-application 6.0 via #1027. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#856, adopting craft-application 5 across 49 files (+959/-915) after approval by three reviewers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#5349 to update Snapcraft’s application framework to craft-application 5 after three approvals. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer-led refactor updating dependencies to craft-application 5. The change was integrated directly without comments or revisions, confirming straightforward compliance with project standards. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#1027
(confidence 80%)
Follow-up merged as bfa24b25, upgrading craft-application from 5 to 6.0 on top of this refactor
-
Related To:
canonical/rockcraft#1029
(confidence 65%)
Further craft-application 6.0.1 bump (commit 8a7ad72e) continuing the dependency line introduced here
-
Related To:
canonical/rockcraft#346
(confidence 60%)
Closed issue whose discussion is linked to commit 2139bcd2 as the craft-application 5 refactor
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395. | |
| #316 Rebase "rockcraft pack" onto craft-application framework | rockcraft | closed | Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| #1027 build(deps): update craft-application to 6.0 | rockcraft | merged | Merged PR #1027 as commit bfa24b25, upgrading craft-application to 6.0 so Rockcraft could use ubuntu@26.04 as its devel base. | |
| #465 refactor: use package-repositories support from craft-app | rockcraft | closed | Rockcraft #465 was closed unmerged after 867 days without review, CI, or comments; its craft-app package-repositories refactor was abandoned. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1072 build(deps): update craft-application and craft-parts | rockcraft | closed | Closed unmerged and superseded by canonical/rockcraft#1073, which merged the same craft-application 6.1.0 and craft-parts 2.28.0 update in commit d5f711b2. | |
| #353 refactor(cli): add scaffolding for craft-application | rockcraft | merged | PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback. | |
| #485 Update to craft-application@main | rockcraft | merged | Merged in PR #485, updating to craft-application@main; three commits added BuildPlanner work and removed obsolete Rockcraft code. | |
| #372 Merge `rockcraft` | craft-application | merged | PR #372 merged into the temporary 2.x branch, adding reviewed rockcraft work and commit ccfe498d's corrected craft-cli/craft-parts constraints for the planned 2.9.0 release. |