refactor: use craft-application 5
Metadata
Current evaluation
Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer-led refactor updating dependencies to craft-application 5. The change was integrated directly without comments or revisions, confirming straightforward compliance with project standards. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring update to upgrade the codebase to craft-application version 5. The change was integrated directly without additional review comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5349 refactor: rebase onto craft-application 5 | snapcraft | merged | Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks. | |
| #2360 chore: upgrade to craft-application 5 | charmcraft | merged | Merged the upgrade to craft-application 5. Approved by four reviewers, the maintainer proceeded with the merge despite failing CI tests, confirming they were pre-existing failures on main unrelated to this change. |