← Back to issue list

providers: deprecate RockcraftBuilddBaseConfiguration

View original Github issue

Metadata

Project
rockcraft
Number
#72
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers BuilddBase and compatibility tags; no functional changes.

Resolution: closed resolved

Reason: PR #72 was merged as commit 7747a03d. It adopted compatibility tags for base definitions and removed the obsolete local BuilddBase configuration class.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Use the compatibility tag parameter when defining a base. This was the last reason `rockcraft` was using `RockcraftBuilddBaseConfiguration`. Because the class `RockcraftBuilddBaseConfiguration` no longer is needed, its parent class `BuilddBase` in `craft-providers` is used instead. No functional changes. (CRAFT-1348)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers BuilddBase and compatibility tags; no functional changes.
stealth/space-bunny-alpha — closed resolved Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers' BuilddBase and compatibility tags; no functional changes.
stealth/space-bunny-alpha — closed resolved Merged PR #72 in commit 7747a03d, replacing RockcraftBuilddBaseConfiguration with craft-providers' BuilddBase and compatibility tags. No functional changes.
stealth/space-bunny-alpha — closed resolved Merged in #72 (7747a03d): deprecated RockcraftBuilddBaseConfiguration and switched base definitions to BuilddBase compatibility tags; no functional changes.
qwen/qwen3.6-35b-a3b — — Merged deprecation of RockcraftBuilddBaseConfiguration, replacing it with BuilddBase using a compatibility tag parameter. Removes the custom class with no functional impact. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged deprecation of RockcraftBuilddBaseConfiguration. Replaced with the parent BuilddBase class from craft-providers via a compatibility tag parameter. No functional changes. Closes CRAFT-1348.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#120 (confidence 60%)

    Later provider-interface work further migrated Rockcraft to the shared craft-providers implementation.

Related issues

Issue Project State Summary Similarity
#3934 providers: deprecate SnapcraftBuilddBaseConfiguration snapcraft merged Merged PR #3934 (commit f6abc2efd), replacing the custom buildd configuration with craft-providers BuilddBase and moving compatibility-tag setup to its constructor.
86%
#1281 build(deps): update craft-providers to 3.7.1 rockcraft merged PR #1281 merged: bumped craft-providers 3.7.0 -> 3.7.1 in rockcraft requirements (2 files, +5/-5), fixing 'build-base: devel' stonking failures and proxy env forwarding to pro methods.
76%
#1019 build: update craft-providers rockcraft merged Merged PR canonical/rockcraft#1019 (commit 841f7432, "build: update craft-providers"), a 3-line dependency bump to craft-providers that fixed "EOL devel" base errors in spread tests; snap-tests failures were confirmed expected.
75%
#4204 providers: remove deprecated `build_base` parameter snapcraft merged Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls.
74%
#24 requirements: update craft-providers rockcraft merged Merged canonical/rockcraft#24 via commit 33d0b2b7, updating craft-providers to 1.2.0 for significantly faster build-instance warm starts.
74%
#892 (internal) Remove CharmcraftBuilddBaseConfiguration and use BuilddBase directly (CRAFT-1278, CRAFT-1356). charmcraft merged Merged #892, removing CharmcraftBuilddBaseConfiguration and using BuilddBase directly; commit 57313bc3 was merged as 834a4fd4.
72%
#4505 chore: remove deprecated parameter `build-base` snapcraft merged PR #4505 merged as 4aa5f63cb, dropping the deprecated build_base arg passed to craft-providers to silence its deprecation warning; the same cleanup had already landed on main via PR #4204 (d77b51466).
71%
#403 build(deps): bump craft-providers to 1.19.2 rockcraft merged Merged PR #403 (commit 4da091b6) bumped craft-providers to 1.19.2 in Rockcraft's frozen requirements, adopting base-v3 to fix LXD instances created with craft-providers 1.16.0 failing to start.
71%
#835 build(deps): use dev craft-providers craft-application closed PR #835 was closed unmerged; its underlying provider test failure was fixed by merged PR #838 in commit 6b237f12.
70%
#164 dependencies: update craft-providers to 1.6.2 rockcraft merged Merged in rockcraft#164 via commit 9696779b, upgrading craft-providers to 1.6.2 to disable automatic snap refreshes inside build instances.
70%