← Back to issue list

chore: remove flake8 and pydocstyle

View original Github issue

Metadata

Project
rockcraft
Number
#739
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged removal of flake8 and pydocstyle in favor of ruff. Approved by two reviewers, passed CI, and updated four files with a net reduction of 53 lines.

Suggested action:

No scores available.

Issue body

Both of these have been replaced with ruff. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of flake8 and pydocstyle in favor of ruff. Approved by two reviewers, passed CI, and updated four files with a net reduction of 53 lines.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer-led changes removing flake8 and pydocstyle, replacing both with ruff for linting and documentation style enforcement.
qwen3.6-35b-a3b-mtp-q6 Merged a chore update removing flake8 and pydocstyle, as both were replaced by ruff. The change was integrated directly into the codebase without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1941 fix(templates): replace flake8 and pydocstyle with ruff charmcraft merged Merged changes replacing flake8 and pydocstyle with ruff in the templates directory. Approved by three reviewers, the update modifies 14 files and resolves issue #1461.
82%
#317 chore: update ruff configuration for 0.8 craft-cli merged Merged. Removed two unsupported linter rules from pyproject.toml to align with ruff 0.8. Approved by two reviewers, passed CI, and merged after auto-format resolved remaining linting errors.
77%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
77%
#363 chore: remove use of black in favor of ruff starbase merged Merged a maintainer's change removing dangling references to the black formatter and replacing it with ruff. Approved by two reviewers, passed CI, and modified one file with minimal changes.
77%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
77%
#204 chore: use ruff snap starbase merged Merged "chore: use ruff snap". Approved by 3 reviewers and passed CI checks. Modified 4 files with a net diff of +5/-5 lines.
76%
#2229 style: fix linting errors charmcraft merged Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
76%
#122 chore: eliminate pydantic warnings craft-archives merged Merged after two approvals and passing CI. Refactored three files to eliminate pydantic deprecation warnings, adding 24 lines and removing 15.
76%
#22 chore(lint): update ruff and config starbase merged Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change.
76%
#4817 style: remove pylint snapcraft merged Merged removal of pylint configuration, fully replaced by ruff. Approved by three reviewers, passed CI checks, and modified 46 files across the codebase.
75%