← Back to issue list

chore: remove flake8 and pydocstyle

View original Github issue

Metadata

Project
rockcraft
Number
#739
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #739, removing flake8 and pydocstyle after replacing them with Ruff; commit 6939aba5.

Resolution: closed resolved

Reason: PR #739 was merged with two approvals and no unresolved review comments. Commit 6939aba5 removed the obsolete tools while retaining Ruff for linting and formatting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Both of these have been replaced with ruff. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #739, removing flake8 and pydocstyle after replacing them with Ruff; commit 6939aba5.
stealth/space-bunny-alpha — closed resolved Merged the cleanup removing flake8 and pydocstyle, completing their replacement with ruff; four files changed.
qwen/qwen3.6-35b-a3b — — Merged removal of flake8 and pydocstyle in favor of ruff. Approved by two reviewers, passed CI, and updated four files with a net reduction of 53 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged maintainer-led changes removing flake8 and pydocstyle, replacing both with ruff for linting and documentation style enforcement.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
78%
#1941 fix(templates): replace flake8 and pydocstyle with ruff charmcraft merged Merged PR #1941 (commit 9aba24c4) replaced flake8 and pydocstyle with Ruff in Charmcraft templates, resolving #1461.
77%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
75%
#288 lint: add ruff, remove autoflake, flake8, isort, pydocstyle, pylint craft-providers merged Merged PR #288 in commit 42a7920, replacing autoflake, flake8, isort, pydocstyle, and pylint with Ruff; deferred Ruff rule cleanup was tracked in #287.
73%
#317 chore: update ruff configuration for 0.8 craft-cli merged Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8.
73%
#700 chore: update ruff craft-parts merged Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702.
73%
#200 chore(deps): update ruff and its configuration craft-application merged Merged into main via commit 07ef33dc, updating Ruff and its configuration; two reviewers approved and no unresolved comments remained.
73%
#1461 Replace flake8 and pydocstyle template tests with ruff charmcraft closed Ruff replaced flake8 and pydocstyle in Charmcraft template validation via merged PR #1941 (commit 9aba24c4).
72%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724.
72%
#62 chore(deps): update bugfixes starbase merged Merged dependency updates in #62 via commit 1949d4c: Ruff 0.0.256→0.0.267 and Pyright/types 1.1.306→1.1.308.
72%