← Back to issue list

style: replace yamllint with prettier

View original Github issue

Metadata

Project
rockcraft
Number
#794
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged #794, replacing yamllint with Prettier and reformatting 95 files; it fixed #791. The change was ported from starbase#305 and generated with make format-prettier.

Resolution: closed resolved

Reason: PR #794 was merged after approval and explicitly states that it fixes #791. It introduced Prettier for YAML formatting and updated expected default outputs, with tests confirming the template changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR has a series of commits. The first one is a "manual cherry-pick" of [starbase/805](https://github.com/canonical/starbase/pull/305), and [this one](https://github.com/canonical/rockcraft/pull/794/commits/177b16121781ea6d3f5612a28ac482120328dacf) is the automated result of running `make format-prettier` (no manual changes). Spread failure is unrelated! Fixes #791 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #794, replacing yamllint with Prettier and reformatting 95 files; it fixed #791. The change was ported from starbase#305 and generated with make format-prettier.
stealth/space-bunny-alpha — closed resolved Merged PR #794 replaced yamllint with Prettier for YAML linting and formatting, updating affected templates and test fixtures and resolving #791.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#794, replacing yamllint with Prettier and reformatting 95 files; fixes #791.
qwen/qwen3.6-35b-a3b — — Merged changes replacing yamllint with prettier for YAML formatting. Automated formatting updated 95 files, approved by three reviewers, and resolves #791. Test expectations were automatically regenerated to match prettier output.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced yamllint with prettier for YAML formatting. Automated formatting updated templates and test fixtures, resolving issue #791 without manual intervention.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#791 (confidence 100%)

    The YAML linting request was explicitly fixed by merged PR #794.

  • Related To: canonical/starbase#305 (confidence 100%)

    Its yamllint-to-Prettier change was manually ported into rockcraft PR #794.

Related issues

Issue Project State Summary Similarity
#305 style: replace yamllint with prettier starbase merged Merged PR canonical/starbase#305 (commit 68d8d79, CRAFT-3626) swapped yamllint for Prettier in pre-commit and common.mk, covering YAML, JSON, JSON5, CSS and Markdown; TOML excluded pending prettier/prettier#15141. Closes #273.
89%
#2265 chore: migrate from yamllint to prettier charmcraft merged Merged as commit 0e124cfd: pre-commit yamllint hook dropped and Prettier (3.6.0) added for yaml/yml/json/md formatting, ported from starbase; 22 files re-formatted.
82%
#273 Replace `yamllint` with `prettier` starbase closed Resolved by merged PR #305 (commit 68d8d79), replacing yamllint with Prettier for YAML, JSON/JSON5, Markdown and CSS; TOML was excluded due to prettier/prettier#15141.
80%
#411 style: autoformat with newest prettier starbase merged Merged in canonical/starbase#411 as commit c860142, applying the newest Prettier formatting across three files; all CI checks passed.
79%
#791 Lint yaml files with prettier rockcraft closed Replaced yamllint with Prettier for YAML linting and formatting through merged PR canonical/rockcraft#794.
75%
#2424 style: fix yamllint issues on 2.7 branch charmcraft merged Merged PR #2424 corrected yamllint issues across 16 files on the 2.7 branch.
74%
#144 build(deps): remove yamllint craft-platforms merged Merged PR #144 removed yamllint and updated the pre-commit configuration from Starbase in commit 35b75fc.
73%
#362 chore: remove unused yamllint dependency starbase merged Merged #362 in commit 8e2c469, removing the unused yamllint dependency from three files after YAML linting had moved to Prettier.
72%
#11 tools: add yamllint starbase merged Merged PR canonical/starbase#11 as commit 5a0d09f, adding optional yamllint tooling and configuration across three files.
72%