← Back to issue list

Replace `yamllint` with `prettier`

View original Github issue

Metadata

Project
starbase
Number
#273
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by merged PR #305 (commit 68d8d79), replacing yamllint with Prettier for YAML, JSON/JSON5, Markdown and CSS; TOML was excluded due to prettier/prettier#15141.

Resolution: closed resolved

Reason: PR #305 merged commit 68d8d79 and implemented the agreed Prettier migration. TOML was intentionally omitted because prettier/prettier#15141 remained unresolved.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Replace yamllint with prettier, as agreed by the team. This should include: - `lint-yaml` Makefile target to lint yaml files with prettier (e.g. `npx prettier --check snap/snapcraft.yaml`) - `format-yaml` Makefile target to format yaml files with prettier (e.g. `npx prettier --write snap/snapcraft.yaml`) - Likewise for JSON files - Likewise for Markdown files - TOML: https://github.com/un-ts/toml-tools/tree/master/packages/prettier-plugin-toml

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #305 (commit 68d8d79), replacing yamllint with Prettier for YAML, JSON/JSON5, Markdown and CSS; TOML was excluded due to prettier/prettier#15141.
stealth/space-bunny-alpha — closed resolved Merged canonical/starbase#305 replaced yamllint with Prettier for YAML, JSON/JSON5, Markdown and CSS. TOML support was excluded due to prettier/prettier#15141.
qwen/qwen3.6-35b-a3b — — Closed without implementation. Scope expanded to include TOML, but no code changes, merge, or resolution details were recorded, indicating the request was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation. No pull request or resolution was provided to replace yamllint with prettier for YAML, JSON, Markdown, and TOML files. The request appears abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by internal Jira ticket CRAFT-3626. No external pull request was merged. Scope expanded to include TOML, but yamllint remains in use without the requested prettier integration.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/starbase#305 (confidence 99%)

    Merged commit 68d8d79 replaced yamllint with Prettier for the supported formats.

  • Related To: prettier#15141 (confidence 95%)

    The open Prettier TOML-plugin limitation prevented TOML support in the resolving change.

Related issues

Issue Project State Summary Similarity
#305 style: replace yamllint with prettier starbase merged Merged PR canonical/starbase#305 (commit 68d8d79, CRAFT-3626) swapped yamllint for Prettier in pre-commit and common.mk, covering YAML, JSON, JSON5, CSS and Markdown; TOML excluded pending prettier/prettier#15141. Closes #273.
88%
#791 Lint yaml files with prettier rockcraft closed Replaced yamllint with Prettier for YAML linting and formatting through merged PR canonical/rockcraft#794.
81%
#794 style: replace yamllint with prettier rockcraft merged Merged #794, replacing yamllint with Prettier and reformatting 95 files; it fixed #791. The change was ported from starbase#305 and generated with make format-prettier.
80%
#2265 chore: migrate from yamllint to prettier charmcraft merged Merged as commit 0e124cfd: pre-commit yamllint hook dropped and Prettier (3.6.0) added for yaml/yml/json/md formatting, ported from starbase; 22 files re-formatted.
80%
#362 chore: remove unused yamllint dependency starbase merged Merged #362 in commit 8e2c469, removing the unused yamllint dependency from three files after YAML linting had moved to Prettier.
76%