← Back to issue list

style: replace yamllint with prettier

View original Github issue

Metadata

Project
starbase
Number
#305
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged after three approvals and passing CI. Replaces yamllint with prettier to auto-format YAML, JSON, JSON5, Markdown, and CSS across 13 files. Resolves #273. TOML support remains pending upstream fixes.

Suggested action: —

No scores available.

Issue body

Lints and formats YAML, JSON, JSON5, Markdown and CSS files with prettier. Cannot do TOML right now due to: https://github.com/prettier/prettier/issues/15141 Fixes #273 CRAFT-3626 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after three approvals and passing CI. Replaces yamllint with prettier to auto-format YAML, JSON, JSON5, Markdown, and CSS across 13 files. Resolves #273. TOML support remains pending upstream fixes.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaces yamllint with prettier to format YAML, JSON, JSON5, Markdown, and CSS. TOML remains unsupported due to a Prettier bug. Resolves #273 and CRAFT-3626 after maintainer confirmed changes were safe.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#794 style: replace yamllint with prettier rockcraft merged Merged changes replacing yamllint with prettier for YAML formatting. Automated formatting updated 95 files, approved by three reviewers, and resolves #791. Test expectations were automatically regenerated to match prettier output.
90%
#2265 chore: migrate from yamllint to prettier charmcraft merged Merged after approval by two reviewers. Migrated YAML linting from yamllint to prettier across 22 files, standardizing formatting and reducing configuration overhead. Core CI checks passed.
81%
#791 Lint yaml files with prettier rockcraft closed Closed without implementation. The request to replace yamllint with prettier was superseded by an internal Jira ticket (CRAFT-3977) via automated sync. No code changes were merged.
76%
#273 Replace `yamllint` with `prettier` starbase closed Closed without implementation. Scope expanded to include TOML, but no code changes, merge, or resolution details were recorded, indicating the request was abandoned.
75%
#255 style: autoformat with ruff 0.9 craft-store merged Merged following two approvals. Applied ruff 0.9 autoformatting across five files, altering 22 lines. All CI checks passed. A maintainer noted that switching from yamllint to prettier will resolve remaining linting concerns.
74%
#2424 style: fix yamllint issues on 2.7 branch charmcraft merged Merged after two approvals. Resolved yamllint compliance issues across 16 files on the 2.7 branch, applying 54 additions and 88 deletions. Core CI checks passed, integrating the style fix.
73%
#411 style: autoformat with newest prettier starbase merged Merged after two approvals and passing CI. The pull request applied automatic formatting using the latest Prettier version, updating three files with a net reduction of 10 lines.
73%
#11 tools: add yamllint starbase merged Merged maintainer lengau's addition of yamllint as an optional linting tool. Approved by two reviewers with zero unresolved comments. The change updates three files, adding 17 lines and removing 2, with no CI checks reported.
72%
#1421 build: enable yamllint charmcraft merged Merged changes to enable yamllint in the build configuration. Approved by two reviewers, the update modifies 15 files (+41/-50 lines) to enforce YAML linting standards across the project.
70%