← Back to issue list

style: replace yamllint with prettier

View original Github issue

Metadata

Project
starbase
Number
#305
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/starbase#305 (commit 68d8d79, CRAFT-3626) swapped yamllint for Prettier in pre-commit and common.mk, covering YAML, JSON, JSON5, CSS and Markdown; TOML excluded pending prettier/prettier#15141. Closes #273.

Resolution: closed resolved

Reason: The PR was approved by 3 reviewers and merged into main as commit 68d8d79 'style: replace yamllint with prettier (#305)', explicitly declaring 'Fixes #273'. The repo now has no yamllint references and runs mirrors-prettier in .pre-commit-config.yaml plus format-prettier/lint-prettier targets in common.mk; a follow-up (#332) later corrected the prettier glob.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Lints and formats YAML, JSON, JSON5, Markdown and CSS files with prettier. Cannot do TOML right now due to: https://github.com/prettier/prettier/issues/15141 Fixes #273 CRAFT-3626 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/starbase#305 (commit 68d8d79, CRAFT-3626) swapped yamllint for Prettier in pre-commit and common.mk, covering YAML, JSON, JSON5, CSS and Markdown; TOML excluded pending prettier/prettier#15141. Closes #273.
stealth/space-bunny-alpha — closed resolved Merged PR #305 replaced yamllint with Prettier for YAML, JSON, JSON5, Markdown and CSS, fixing #273; TOML was excluded due to Prettier#15141.
qwen/qwen3.6-35b-a3b — — Merged after three approvals and passing CI. Replaces yamllint with prettier to auto-format YAML, JSON, JSON5, Markdown, and CSS across 13 files. Resolves #273. TOML support remains pending upstream fixes.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaces yamllint with prettier to format YAML, JSON, JSON5, Markdown, and CSS. TOML remains unsupported due to a Prettier bug. Resolves #273 and CRAFT-3626 after maintainer confirmed changes were safe.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/starbase#273 (confidence 97%)

    Issue 'Replace yamllint with prettier' that this PR explicitly fixes.

  • Blocked By: prettier#15141 (confidence 88%)

    Upstream Prettier limitation blocking TOML formatting, cited in the PR body as the reason TOML is not covered.

  • Related To: canonical/starbase#332 (confidence 72%)

    Follow-up merged commit 3b7289b 'fix(common.mk): fix glob of prettier files' correcting this PR's file glob.

  • Related To: canonical/starbase#411 (confidence 60%)

    Later commit c860142 'style: autoformat with newest prettier' re-ran formatting with a newer Prettier.

Related issues

Issue Project State Summary Similarity
#794 style: replace yamllint with prettier rockcraft merged Merged #794, replacing yamllint with Prettier and reformatting 95 files; it fixed #791. The change was ported from starbase#305 and generated with make format-prettier.
89%
#273 Replace `yamllint` with `prettier` starbase closed Resolved by merged PR #305 (commit 68d8d79), replacing yamllint with Prettier for YAML, JSON/JSON5, Markdown and CSS; TOML was excluded due to prettier/prettier#15141.
88%
#2265 chore: migrate from yamllint to prettier charmcraft merged Merged as commit 0e124cfd: pre-commit yamllint hook dropped and Prettier (3.6.0) added for yaml/yml/json/md formatting, ported from starbase; 22 files re-formatted.
82%
#791 Lint yaml files with prettier rockcraft closed Replaced yamllint with Prettier for YAML linting and formatting through merged PR canonical/rockcraft#794.
79%
#411 style: autoformat with newest prettier starbase merged Merged in canonical/starbase#411 as commit c860142, applying the newest Prettier formatting across three files; all CI checks passed.
78%
#11 tools: add yamllint starbase merged Merged PR canonical/starbase#11 as commit 5a0d09f, adding optional yamllint tooling and configuration across three files.
77%
#144 build(deps): remove yamllint craft-platforms merged Merged PR #144 removed yamllint and updated the pre-commit configuration from Starbase in commit 35b75fc.
76%
#362 chore: remove unused yamllint dependency starbase merged Merged #362 in commit 8e2c469, removing the unused yamllint dependency from three files after YAML linting had moved to Prettier.
72%
#62 feat(renovate): update prettier starflow merged Merged PR #62 added a Renovate rule to enable Prettier updates using canonical/starbase#411 configuration; review approval and all CI checks passed.
72%
#291 lint: add shellcheck, yamllint craft-providers merged Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287.
71%