← Back to issue list

docs: add references to lifecycle and part properties

View original Github issue

Metadata

Project
rockcraft
Number
#850
Type
pull request
State
open
Author
alesancor1
Labels
—
Created
Updated
Closed
—

Current evaluation

Docs-only PR (+6/-6, 4 files) adding lifecycle and part-property cross-references in the craft-parts common/ docs. changes_requested with 4 unresolved comments, idle 413 days, and the upstream companion PR was rejected.

Suggested action: close stale

Reason: The PR is a draft docs-only tweak (+6/-6) to files under docs/common/craft-parts/, which are now synced from the craft-parts repo (rockcraft's docs/reference/parts-and-steps.rst is just `.. include::` directives for /common/craft-parts/reference/*.rst). Review status is changes_requested with 4 unresolved review comments and zero maintainer response for 413 days, and the companion upstream PR canonical/craft-parts#1053 was closed unmerged because maintainers said the cross-links reverse the structure set by craft-parts#1162 ("docs: remove internal links in common directory", merged), which deliberately stripped internal links from the common directory. The approach is thus obsolete for this repo as well as abandoned.

Evaluated by: mr-cal-bot

Impact: 15 Quick Win: 2 Complexity: 15 Confidence: 72 Actionability: 12

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- This PR add references to lifecycle docs page and part properties on every occurrence of <lifecycle step> Also check the PR for craft-parts: https://github.com/canonical/craft-parts/pull/1053 --- See built page [here](https://canonical-ubuntu-documentation-library--850.com.readthedocs.build/rockcraft/en/850/)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 15
Quick Win: 2
Complexity: 15
Confidence: 72
Actionability: 12
close stale Docs-only PR (+6/-6, 4 files) adding lifecycle and part-property cross-references in the craft-parts common/ docs. changes_requested with 4 unresolved comments, idle 413 days, and the upstream companion PR was rejected.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 1
Complexity: 5
Confidence: 75
Actionability: 10
close stale Documentation PR adding references to lifecycle docs and part properties. Draft with 4 unresolved review comments, inactive for 400 days. Related craft-parts PR #1053 was rejected by maintainers.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 9
Staleness: 82
Complexity: 10
Confidence: 80
close stale Docs PR adding lifecycle and part properties cross-references; 521 days old, changes requested with 4 unresolved comments, companion craft-parts PR rejected, docs since restructured to include these references via common craft-parts mechanism.
qwen/qwen3.6-35b-a3b
Staleness: 92
Complexity: 5
Confidence: 85
close stale Updates documentation to add references to lifecycle and part properties across four files. Currently marked as changes requested with 4 unresolved review comments and no recent activity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 10
Confidence: 85
close stale Adds documentation references to lifecycle steps and part properties. Inactive for over 326 days with no maintainer feedback or CI status.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 10
Confidence: 85
close stale Updates documentation to add references to lifecycle and part properties across all occurrences. Currently inactive for over a year with no maintainer feedback or CI status.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#1053 (confidence 90%)

    Explicitly cited companion PR in this PR's body; closed unmerged after maintainer objections to the same lifecycle-doc cross-linking approach.

  • Superseded By: canonical/craft-parts#1162 (confidence 78%)

    Merged upstream change removing internal links from the craft-parts common/ docs that rockcraft syncs and includes; conflicts with the cross-references this PR adds.

Related issues

Issue Project State Summary Similarity
#314 docs: clean up references to Craft Parts rockcraft closed Craft Parts documentation cleanup was folded into canonical/rockcraft#308, merged as commit 13bf8368, and #314 was closed.
73%
#247 docs: include some docs from craft-parts rockcraft closed PR pulling craft-parts docs into rockcraft was left unmerged and closed as redundant; the same docs refactor landed instead via rockcraft#515 (commit 5c2263f1, "refactor(docs): use more docs from craft-parts").
72%
#308 docs: imported the part properties reference from Craft Parts rockcraft merged Imported Craft Parts' part-properties reference into Rockcraft docs; PR #308 merged as 13bf8368 after upstream craft-parts#483 and #486 enabled and corrected the reusable documentation.
71%
#25 parts: add PartsLifecycle support craft-application merged Merged PR #25 as commit 3fa6c712, adding PartsLifecycle support for CRAFT-1752 with tests and 100% diff coverage.
71%
#1195 docs: remove Craft Parts links from docstrings craft-parts merged PR #1195 merged as commit fa440b8c, stripping Craft Parts links from PartSpec field docstrings so downstream consumers can supply versioned internal references; changelog entry added under2.20.0.
70%
#5332 docs: migrate 'parts lifecycle' snapcraft merged Merged the parts lifecycle documentation migration in PR #5332, updating five files (+272/-27); landed as commit fc43c788d.
70%