← Back to issue list

fix: Removed reference to snapcraft.yaml in expand extensions

View original Github issue

Metadata

Project
rockcraft
Number
#885
Type
pull request
State
open
Author
RafaelJohn9
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes a snapcraft.yaml reference from expand-extensions help text (1 line, fixes #658). Approved, CI green, but untouched for 212 days and superseded by newer approved PR #1103, which makes the same correction more completely.

Suggested action: close superseded

Reason: rockcraft#1103 (open, approved, all CI passing, no unresolved comments) implements the same #658 correction more completely — 2 lines covering help_msg and the overview wording — whereas this PR's +1/-1 touches only help_msg and leaves the docstring 'Expand the extensions in the snapcraft.yaml file.' intact. The maintainer pattern is decisive: #1111 and #1210 were each closed unmerged as duplicates of #1103. Verified via pickaxe that HEAD still contains the bug (last touched by e8858077/#292) and that #885's commit is absent, so it was not merged and nothing else supersedes #1103.

Evaluated by: mr-cal-bot

Impact: 15 Quick Win: 8 Complexity: 5 Confidence: 87 Actionability: 55

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Fixes: #658

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 15
Quick Win: 8
Complexity: 5
Confidence: 87
Actionability: 55
close superseded Removes a snapcraft.yaml reference from expand-extensions help text (1 line, fixes #658). Approved, CI green, but untouched for 212 days and superseded by newer approved PR #1103, which makes the same correction more completely.
stealth/space-bunny-alpha
Impact: 15
Quick Win: 9
Complexity: 3
Confidence: 86
Actionability: 65
close superseded One-line fix in rockcraft/commands/extensions.py changing expand-extensions help_msg from "snapcraft.yaml" to "rockcraft.yaml" (fixes #658). Approved by 2 reviewers, all CI green, but the same fix was re-submitted as #1103.
stealth/space-bunny-alpha
Impact: 12
Quick Win: 3
Complexity: 4
Confidence: 86
Actionability: 28
close superseded One-line fix replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions help (Fixes #658). Approved with all CI green, but stale (212 days idle) and now duplicated by newer rockcraft#1103.
stealth/space-bunny-alpha
Impact: 12
Quick Win: 4
Complexity: 2
Confidence: 87
Actionability: 30
close superseded One-line help-text fix replacing snapcraft.yaml with rockcraft.yaml in expand-extensions (fixes #658). Approved with all CI green, but superseded by canonical/rockcraft#1103 which makes the same correction.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 11
Complexity: 5
Confidence: 85
Actionability: 80
needs review Removes snapcraft.yaml reference from expand-extensions help text in rockcraft. Approved by 2 reviewers, all CI passing, awaiting maintainer merge.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 55
Complexity: 5
Confidence: 85
needs review One-line fix removing the snapcraft.yaml reference from the expand-extensions help text and docstring, fixing #658. Approved by 2 reviewers with all CI checks green, but unmerged and inactive ~6 months; the fix is still unapplied in the codebase.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 5
Confidence: 90
needs review Trivial one-line fix removing a reference to snapcraft.yaml in expand extensions. Approved by two reviewers, all CI checks pass, but has been inactive for over 14 months awaiting maintainer merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 92
Complexity: 10
Confidence: 65
close stale Removes a reference to snapcraft.yaml in expand extensions. The PR has been open for 415 days with zero maintainer comments or updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 70
close stale Removes a reference to snapcraft.yaml in expand extensions. The PR is over a year old with no maintainer feedback or updates in four months.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#658 (confidence 97%)

    Issue this PR fixes: help entry for expand-extensions wrongly references snapcraft.yaml; still open/unfixed on HEAD.

  • Superseded By: canonical/rockcraft#1103 (confidence 85%)

    Newer approved, CI-green PR making the same #658 help-text fix, more completely (also corrects the overview wording).

  • Duplicate Of: canonical/rockcraft#1210 (confidence 80%)

    Same change, closed unmerged as a duplicate of #1103, confirming maintainers consolidated this fix onto #1103.

  • Duplicate Of: canonical/rockcraft#1111 (confidence 78%)

    Same help-text fix, also closed unmerged as a duplicate of #1103.

  • Related To: canonical/rockcraft#351 (confidence 65%)

    Same class of open snapcraft.yaml-vs-rockcraft.yaml docstring typo, indicating this fix is incomplete even within its file.

Related issues

Issue Project State Summary Similarity
#1103 fix: remove snapcraft.yaml reference from expand-extensions rockcraft open Two-line help/docstring fix in rockcraft/commands/extensions.py replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions. Approved, CI passing, no unresolved comments; verified still applicable to current main.
81%
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows 'expand-extensions: Expand extensions in snapcraft.yaml', a copy-paste leftover; rockcraft.yaml is the correct file. Still present at HEAD; fixes #885/#1103 approved but unmerged.
74%
#4110 extensions: parse snapcraft.yaml before expanding extensions snapcraft merged Merged #4110 (commit 51ca1524b): expand-extensions now parses snapcraft.yaml before expansion, fixing valid core22 files that use parse-info and advanced grammar keywords.
73%
#146 Syntax of snapcraft.yaml (1.x) snapcraft merged PR #146 was merged, updating the snapcraft.yaml 1.x syntax reference after review, rebase, and squash; it built on merged PR #131.
71%
#3679 Expand extensions snapcraft merged Merged PR snapcore/snapcraft#3679 via commit 07a8d695c, expanding extensions for CRAFT-948 in the snapcraft/7.0 branch.
71%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing.
71%
#6043 docs: remove duplicate app keys from 'snapcraft.yaml' snapcraft merged Docs-only PR merged as commit 6a43e5742 ("docs: remove duplicate app keys from 'snapcraft.yaml'"), fixing a copy-paste duplication in the snapcraft.yaml reference after 3 approvals; +6/-4 lines in one doc file.
70%