fix: Removed reference to snapcraft.yaml in expand extensions
Metadata
Current evaluation
One-line fix removing the snapcraft.yaml reference from the expand-extensions help text and docstring, fixing #658. Approved by 2 reviewers with all CI checks green, but unmerged and inactive ~6 months; the fix is still unapplied in the codebase.
Suggested action: needs review
Reason: The PR has 2 approvals, all CI checks passing, and 0 unresolved comments, and it fixes still-open issue #658. I verified the snapcraft.yaml references remain in rockcraft/commands/extensions.py (lines 85, 88), so the fix is unapplied and the PR is ready to be landed by a maintainer. A newer duplicate PR #1103 exists, but this older PR is the canonical one.
Impact:
10
Quick Win:
9.5
Staleness:
55
Complexity:
5
Confidence:
85
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Fixes: #658
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
10
Quick Win:
9.5
Staleness:
55
Complexity:
5
Confidence:
85
|
needs review | One-line fix removing the snapcraft.yaml reference from the expand-extensions help text and docstring, fixing #658. Approved by 2 reviewers with all CI checks green, but unmerged and inactive ~6 months; the fix is still unapplied in the codebase. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
5
Confidence:
90
|
needs review | Trivial one-line fix removing a reference to snapcraft.yaml in expand extensions. Approved by two reviewers, all CI checks pass, but has been inactive for over 14 months awaiting maintainer merge. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
92
Complexity:
10
Confidence:
65
|
close stale | Removes a reference to snapcraft.yaml in expand extensions. The PR has been open for 415 days with zero maintainer comments or updates. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
10
Confidence:
70
|
close stale | Removes a reference to snapcraft.yaml in expand extensions. The PR is over a year old with no maintainer feedback or updates in four months. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
10
Confidence:
80
|
close stale | Removes a reference to snapcraft.yaml in expand extensions to fix issue #658. The pull request has seen no comments or activity in over 100 days, leaving it in a stale state awaiting review or maintainer action. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
rockcraft#658
(confidence 90%)
PR body states 'Fixes: #658'; issue is still open and the snapcraft.yaml references it reports are confirmed present in rockcraft/commands/extensions.py.
-
Related To:
rockcraft#1103
(confidence 80%)
#1103 is a newer PR making the same fix (3 lines, 1 file), also approved with CI green; it is itself described as likely a duplicate of this older PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1103 fix: remove snapcraft.yaml reference from expand-extensions | rockcraft | open | Removes snapcraft.yaml references from expand-extensions help text and docstring (3 lines, 1 file). Approved with CI green, but inactive ~6 months; fix still unapplied in codebase; likely duplicate of older PR #885. | |
| #4110 extensions: parse snapcraft.yaml before expanding extensions | snapcraft | merged | Merged fix for the expand-extensions command to parse snapcraft.yaml before expanding extensions. Resolves core22 parsing issues with parse-info and advanced grammar keywords. Approved, passed CI, and merged into main. | |
| #3679 Expand extensions | snapcraft | merged | Merged into snapcraft/7.0 after approval and passing CI checks. The changes expand extensions, address CRAFT-948, and increased overall coverage by 0.17%. | |
| #292 extensions: add cli commands | rockcraft | merged | Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines). | |
| #658 Help includes expand-extensions entry with reference to snapcraft.yaml | rockcraft | open | rockcraft help --all shows expand-extensions referencing snapcraft.yaml instead of rockcraft.yaml. Bug still present in code; two approved but unmerged PRs (#885, #1103) fix the help text. Labeled good first issue, no maintainer activity since 2024. | |
| #334 fix: apply yaml transforms first | craft-application | merged | Merged fix ensuring _extra_yaml_transforms execute before project variable evaluation. Resolves snapcraft#4771 by allowing extensions that inject project variables to function correctly. Approved by two reviewers and passed CI checks. | |
| #1417 fix: expand-extensions overview | charmcraft | merged | Merged into main. This pull request fixes the expand-extensions overview for the craft-application based command, mirroring PR #1416. Approved by two reviewers with passing CI checks, the change modifies one file with five additions and two deletions. | |
| #2348 extensions: remove root extensions | snapcraft | merged | Merged removal of root extension declarations from snapcraft.yaml. Resolves LP #1797631 by deferring application scope decisions until usage patterns clarify. Approved by maintainer, passed CI, and modified two files. | |
| #2349 extensions: use extension docstring | snapcraft | merged | Merged into master. Replaces the generic snapcraft extension description with extension-specific docstrings, resolving bug LP: #1797655. Approved by reviewer and passed all CI checks. | |
| #4662 fix(test): do not create 2 snapcraft.yaml and confuse location | snapcraft | merged | Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged. |