← Back to issue list

docs: remove duplicate app keys from 'snapcraft.yaml'

View original Github issue

Metadata

Project
snapcraft
Number
#6043
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Docs-only PR merged as commit 6a43e5742 ("docs: remove duplicate app keys from 'snapcraft.yaml'"), fixing a copy-paste duplication in the snapcraft.yaml reference after 3 approvals; +6/-4 lines in one doc file.

Resolution: closed resolved

Reason: The PR was merged into main as commit 6a43e5742, confirmed by the snapcraft commit history entry for #6043. It corrected the duplicated app stanza keys in the snapcraft.yaml documentation (docs-only, +6/-4), with all 3 review approvals and no unresolved comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I blame the reviewers. /s --- - [X] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [X] I've successfully run `make lint && make test`. - [X] I've added or updated any relevant documentation. - [X] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Docs-only PR merged as commit 6a43e5742 ("docs: remove duplicate app keys from 'snapcraft.yaml'"), fixing a copy-paste duplication in the snapcraft.yaml reference after 3 approvals; +6/-4 lines in one doc file.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#6043 as commit 6a43e5742, removing duplicate app keys from the snapcraft.yaml documentation after three approvals.
qwen/qwen3.6-35b-a3b — — Merged after three approvals and passing CI checks. The update removes duplicate app keys from the snapcraft.yaml documentation, adding six lines and removing four across one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation update removing duplicate app keys from snapcraft.yaml. The change passed lint and test checks and was successfully integrated.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3518 (confidence 72%)

    Earlier merged work adding duplicate-key detection/warnings for snapcraft.yaml, motivating the doc cleanup of duplicated app keys.

Related issues

Issue Project State Summary Similarity
#6293 docs: group app keys into general and daemon sections snapcraft merged Merged PR #6293 via commit 16474a7d3, reorganizing snapcraft.yaml app keys into general and daemon-specific sections.
73%
#5566 docs: add part keys to `snapcraft.yaml` reference snapcraft merged Merged PR #5566 (commit aee7fe47c, "docs: add part keys to snapcraft.yaml reference") added updated part-key descriptions to the snapcraft.yaml reference; approved by 2 reviewers and shipped in Snapcraft 8.9.5.
73%
#5681 docs: document the base key snapcraft merged Merged PR #5681 in commit caf905ce5, adding 17 lines documenting the snapcraft.yaml base key.
71%
#2734 SnapcraftError refactoring snapcraft merged SnapcraftError refactoring was merged in canonical/snapcraft#2734 after maintainer approval, updating four files (+279/-26).
71%
#6283 docs: fix syntax for H1 heading snapcraft merged Merged docs-only typo fix to an H1 heading syntax in Snapcraft documentation. Merged to main as commit a85c8fdf8 (PR canonical/snapcraft#6283), a +1/-1 line change with no functional impact.
71%
#885 fix: Removed reference to snapcraft.yaml in expand extensions rockcraft open Removes a snapcraft.yaml reference from expand-extensions help text (1 line, fixes #658). Approved, CI green, but untouched for 212 days and superseded by newer approved PR #1103, which makes the same correction more completely.
70%
#5422 docs: add tutorial snapcraft merged Merged PR #5422 as commit 5c50c42d4, adding a new Snapcraft tutorial and revising 10 documentation files (+795/-90 lines).
70%