← Back to issue list

Needs test for bzr sources

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1536283
Type
issue
State
closed
Author
~fazerlicourice
Labels
—
Created
Updated
Closed

Current evaluation

Fixed by merged GitHub PR #245 (commit 52dfd7d7f), adding unit coverage in tests/unit/sources_tests.py for pulling Bazaar sources from URIs.

Resolution: closed resolved

Reason: PR #245 was merged as commit 52dfd7d7f, resolving LP #1536283 by adding the requested Bazaar-source unit test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The snapcraft/sources.py contains a method that deals with getting bazaar sources and identifying them based on the URI, but this method doesn't have a test associated with it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged GitHub PR #245 (commit 52dfd7d7f), adding unit coverage in tests/unit/sources_tests.py for pulling Bazaar sources from URIs.
stealth/space-bunny-alpha — closed resolved Test coverage gap for bzr sources in snapcraft/sources.py was fixed: PR #245 ('Added a unit tests for pulling bazaar sources from URIs', by fazerlicourice7) was merged as commit 52dfd7d7f, adding bzr cases to tests/unit/sources_tests.py.
stealth/space-bunny-alpha — closed resolved Resolved by fazerlicourice7's PR #245 ("Added a unit tests for pulling bazaar sources from URIs"), merged as commit 52dfd7d7f from branch create-test-for-bzr-sources, adding bzr coverage to tests/unit/sources_tests.py for LP #1536283.
stealth/space-bunny-alpha — closed resolved Added the missing Bazaar source URI test in merged PR #245 (commit 39d732634), covering sources.py method dispatch and pulling bzr sources.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to add tests for the bzr source handling method in snapcraft/sources.py was abandoned due to inactivity, with no tests added or resolution provided.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to add tests for the bzr sources method in snapcraft/sources.py was abandoned after four days with no comments or follow-up.
qwen/qwen3.6-35b-a3b — — Request to add tests for the bzr source identification method in snapcraft/sources.py was closed without implementation. The test coverage gap remains unresolved and the request is abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without action. The request to add tests for the bzr source handling method in snapcraft/sources.py was abandoned after four days with no discussion or implementation.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#245 (confidence 100%)

    Merged as commit 52dfd7d7f with Bazaar source URI test coverage.

Related issues

Issue Project State Summary Similarity
#245 Added a unit tests for pulling bazaar sources from URIs. snapcraft merged Merged PR #245 added a unit test verifying URI method dispatch for Bazaar sources in sources.py (LP #1536283).
87%
#216 Added test for sources.py snapcraft closed Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292).
74%
#233 added test for git sources in sources.py snapcraft merged Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval.
70%