← Back to issue list

added test for git sources in sources.py

View original Github issue

Metadata

Project
snapcraft
Number
#233
Type
pull request
State
merged
Author
fazerlicourice7
Labels
—
Created
Updated
Closed

Current evaluation

Merged after adding tests for git sources in sources.py. Initial assertion fix request was dropped after clarifying the method needs no parameters. Coverage improved, approval granted, and changes merged.

Suggested action: —

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after adding tests for git sources in sources.py. Initial assertion fix request was dropped after clarifying the method needs no parameters. Coverage improved, approval granted, and changes merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged after adding a test for git sources in sources.py. A requested assertion fix was clarified as unnecessary, coveralls passed, and the contribution was approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged external contribution adding tests for git sources in sources.py. Review initially requested an assertion fix, but the author clarified it was unnecessary. Approved after code coverage verification and maintainer sign-off.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#216 Added test for sources.py snapcraft closed Added a test for Git sources in _get_source_type_from_uri. The request closed without merging. Zero reviews and no CI checks indicate the change was abandoned due to inactivity.
75%
#964 sources: refactor git source into module. snapcraft merged Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.
74%
#217 added test for git sources in the get() method in snapcraft/sources.py snapcraft closed Contributor submitted a test for git sources, but the PR closed without merging. Reviewers requested copyright updates, PEP8 fixes, and commit squashing. The author struggled with git rebase and abandoned the PR to start over.
73%