added test for git sources in sources.py
Metadata
Current evaluation
Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval.
Resolution: closed resolved
Reason: The PR (canonical/snapcraft#233) was merged into the snapcraft master branch, adding Git-source tests to tests/unit/test_sources.py. The discussion over a pull() assertion ended when sergiusens confirmed nothing needed fixing ('then it is all good. I'm :+1: but @elopio has the final say'), and the author then requested GCI task approval, which preceded merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#217, adding tests for Git sources in sources.py after maintainer feedback on assertion coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after adding tests for git sources in sources.py. Initial assertion fix request was dropped after clarifying the method needs no parameters. Coverage improved, approval granted, and changes merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after adding a test for git sources in sources.py. A requested assertion fix was clarified as unnecessary, coveralls passed, and the contribution was approved and merged. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#217
(confidence 40%)
Issue corpus metadata suggests #217 (adding git source tests in sources.py) is the upstream issue this PR addressed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #216 Added test for sources.py | snapcraft | closed | Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292). | |
| #217 added test for git sources in the get() method in snapcraft/sources.py | snapcraft | closed | Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292. | |
| #1534411 Needs Test for Git sources | snapcraft (launchpad) | closed | Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411. | |
| #1536283 Needs test for bzr sources | snapcraft (launchpad) | closed | Fixed by merged GitHub PR #245 (commit 52dfd7d7f), adding unit coverage in tests/unit/sources_tests.py for pulling Bazaar sources from URIs. |