← Back to issue list

Added test for sources.py

View original Github issue

Metadata

Project
snapcraft
Number
#216
Type
pull request
State
closed
Author
fazerlicourice7
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292).

Resolution: closed superseded

Reason: The proposed test was superseded by canonical/snapcraft#233, which added the Git-source unit tests and was merged through f909dc292 with commit 106eb8e2d.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Added a test for Git sources in the _get_source_type_from_uri(source) method.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292).
stealth/space-bunny-alpha — closed superseded Git-source test was closed unmerged, then incorporated in merged snapcraft#233 via commit 106eb8e2d (merge f909dc292).
qwen/qwen3.6-35b-a3b — — Added a test for Git sources in _get_source_type_from_uri. The request closed without merging. Zero reviews and no CI checks indicate the change was abandoned due to inactivity.
qwen3.6-35b-a3b-mtp-q6 — — A test for the _get_source_type_from_uri method in sources.py was submitted but closed without merging. The external contribution received no comments or labels, indicating it was abandoned or declined.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#217 added test for git sources in the get() method in snapcraft/sources.py snapcraft closed Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292.
81%
#233 added test for git sources in sources.py snapcraft merged Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval.
78%
#1536283 Needs test for bzr sources snapcraft (launchpad) closed Fixed by merged GitHub PR #245 (commit 52dfd7d7f), adding unit coverage in tests/unit/sources_tests.py for pulling Bazaar sources from URIs.
74%
#1534411 Needs Test for Git sources snapcraft (launchpad) closed Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411.
70%