← Back to issue list

snapcraft clean -s strip doesn't show the deprecation message

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1590256
Type
issue
State
closed
Author
~elopio
Labels
verification-done
Created
Updated
Closed

Current evaluation

Fixed by ubuntu-core/snapcraft PR #556 (commit 83de1df03), released in snapcraft 2.10.1 to xenial -updates; verified by ~elopio and closed as fixed.

Resolution: closed resolved

Reason: Merged PR #556 'Backwards compatible clean with strip' (commit 83de1df03) made `snapcraft clean -s strip` emit the deprecation warning instead of an error, and it shipped in snapcraft 2.10.1/2.10.1+16.10 per the janitor comments. ~elopio confirmed the fix on xenial and the SRU verification completed successfully.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The strip step was renamed to prime. When the old step is run a deprecation message is displayed; but when it is cleaned, an error is shown. $ snapcraft clean -s strip 'strip' is not a valid step for part ... The deprecation message should be displayed also when the strip is cleaned. [Impact] * Users trying to clean the strip step will get an error and no indication about the rename. [Test Case] * Run snapcraft clean -s strip * Make sure that you get the step run and a deprecation message. [Regression Potential] * It could affect the clean prime step. There are tests to avoid that, but a manual check would be good.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by ubuntu-core/snapcraft PR #556 (commit 83de1df03), released in snapcraft 2.10.1 to xenial -updates; verified by ~elopio and closed as fixed.
stealth/space-bunny-alpha — closed resolved Fixed by ubuntu-core/snapcraft PR #556 (commit 83de1df03, "Backwards compatible clean with strip"), making clean -s strip clean prime with a deprecation warning; released in snapcraft 2.10.1 after SRU verification.
stealth/space-bunny-alpha — closed resolved Fixed by commit 83de1df03 (PR #556) "Backwards compatible clean with strip", merged 8 Jun 2016 and shipped in snapcraft 2.10.1 to xenial/-updates; maintainer verified SRU and closed.
stealth/space-bunny-alpha — closed resolved Fixed by merged canonical/snapcraft#556 (83de1df03): clean -s strip now remains backward compatible and displays the strip-to-prime deprecation warning.
qwen/qwen3.6-35b-a3b — — Implemented missing deprecation warning for snapcraft clean -s strip, replacing the previous error. The fix notifies users of the step rename to prime during cleanup. Verified and closed.
qwen/qwen3.6-35b-a3b — — Fixed snapcraft clean -s strip to show a deprecation message instead of an error for the renamed step. The fix was merged and verified.
qwen/qwen3.6-35b-a3b — — Fixed snapcraft to display a deprecation message when cleaning the renamed strip step instead of throwing an error. The change was implemented, verified, and the issue closed.
qwen3.6-35b-a3b-mtp-q6 — — Fixed by updating the clean command to display the deprecation message when the strip step is used, aligning with the prime step rename. The fix was verified and the issue closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#556 (confidence 95%)

    PR referenced in the bug comments and changelog entry 'Backwards compatible clean with strip (#556)'.

  • Related To: ubuntu-core/snapcraft#543 (confidence 70%)

    Commit 1540773f1 'Rename strip to prime (#543)' introduced the deprecation path this bug relates to.

  • Likely Fixed By: snapcraft (launchpad)#1582515 (confidence 60%)

    Originating upstream issue where this LP bug was ported from (per ~sergiusens comment).

Related issues

Issue Project State Summary Similarity
#556 Backwards compatible clean with strip snapcraft merged Merged PR #556 via commit 83de1df03, making clean -s strip call prime with a deprecation warning; released in snapcraft 2.10.1.
74%
#153 Obsolete deprecations from 1.x snapcraft merged Merged PR #153 as commit a4d8464, removing obsolete Snapcraft 1.x deprecation code and messages across 18 files.
71%
#1656265 deprecation notices should be on the guide snapcraft (launchpad) closed Updated deprecation notices to point to the consolidated Snapcraft documentation in snapcore/snapcraft PR #1048 (commit bfd896a11).
71%