← Back to issue list

tourdir unittests fail when the package is build in launchpad

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1589782
Type
issue
State
closed
Author
~elopio
Labels
verification-done
Created
Updated
Closed

Current evaluation

Launchpad builds failed the tourdir unit tests because they hardcoded /usr/share/snapcraft/tour. Fixed by merged PR canonical/snapcraft#551 (commit 4ae5e7a09), released in snapcraft 2.11 and verified into xenial-updates.

Resolution: closed resolved

Reason: The tests were re-enabled and made build-directory-aware by canonical/snapcraft#551, merged as commit 4ae5e7a09 and cited in the snapcraft 2.11 changelog on this bug ("Reenable get and set tourdir unit tests (#551) (LP: #1589782)"). elopio marked it verification-done on 2016-06-13 and ~janitor closed it as fixed in snapcraft 2.11.

Evaluated by: mr-cal-bot

No scores available.

Issue body

https://launchpadlibrarian.net/263350073/buildlog_ubuntu-xenial-amd64.snapcraft_2.9~ppa6-1_BUILDING.txt.gz ====================================================================== FAIL: test_get_default_tourdir (snapcraft.tests.test_common.CommonTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/«PKGBUILDDIR»/snapcraft/tests/test_common.py", line 37, in test_get_default_tourdir '/usr/share/snapcraft/tour', common.get_tourdir()) AssertionError: '/usr/share/snapcraft/tour' != '/«PKGBUILDDIR»/tour' - /usr/share/snapcraft/tour + /«PKGBUILDDIR»/tour ---------------------------------------------------------------------- [Impact] * The tour feature is not yet accessible through the command line interface. * These tests need to be fixed before the feature is published. [Test Case] * N/A, the package will be put in the PPA and launchpad will tell us if it succeeds. [Regression Potential] * This could make the tests fail. But as it's in a build test, any regression will block the new version to get into the PPA we use for testing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Launchpad builds failed the tourdir unit tests because they hardcoded /usr/share/snapcraft/tour. Fixed by merged PR canonical/snapcraft#551 (commit 4ae5e7a09), released in snapcraft 2.11 and verified into xenial-updates.
stealth/space-bunny-alpha — closed resolved tourdir tests failed under Launchpad builds because they assumed /usr/share/snapcraft/tour. Fixed by merged PR #551 (commit 4ae5e7a09); shipped in snapcraft 2.11 (LP: #1589782), verified and released to xenial-updates.
stealth/space-bunny-alpha — closed resolved Launchpad's tourdir test failure was resolved by merged PR #551 (4ae5e7a09), restoring both tests with cleanup that removed shared directory-state dependence; LP bug #1589782 is verification-done.
qwen/qwen3.6-35b-a3b — — Fixed the failing test_get_default_tourdir unittest by correcting path resolution for Launchpad builds. The issue was closed and marked verification-done, ensuring tests pass during package builds.
qwen/qwen3.6-35b-a3b — — Resolved and verified. The unit test expectation for the tour directory path was adjusted to handle both development and Launchpad build environments, fixing the assertion failure during packaging.
qwen/qwen3.6-35b-a3b — — Fixed a Launchpad build failure by updating the tourdir unit test to handle build-time versus installed paths. Resolved and closed as verified.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#551 (confidence 97%)

    Merged PR re-enabling the get/set tourdir tests; commit 4ae5e7a09, credited in the 2.11 changelog on this bug.

  • Related To: canonical/snapcraft#559 (confidence 70%)

    Reenable tour command, shipped in the same 2.11 SRU; elopio noted this fix unblocked it (LP: #1590906).

Related issues

Issue Project State Summary Similarity
#1674952 snapcraft tour broken when installed from snap snapcraft (launchpad) closed Tour failed when snapcraft ran from a snap because it looked in /usr/share/snapcraft/tour. Fixed by merged PR snapcore/snapcraft#1217 (commit d365eb9ed, 'tour: make it work when its a snap'), linked in the closing comment.
71%