Use pymacaroons
Metadata
Current evaluation
Merged canonical/snapcraft#584 in commit 28b94b375, replacing vendored pymacaroons with the packaged library; unit, integration, and snap tests passed.
Resolution: closed resolved
Reason: Commit 28b94b375 implemented PR #584. The maintainer confirmed all autopkgtests passed and merged it despite a cleanup failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Switch from local copy to the proper python package.
LP: #1590813
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#584 in commit 28b94b375, replacing vendored pymacaroons with the packaged library; unit, integration, and snap tests passed. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #584 merged, deleting the ~299-line vendored pymacaroons copy in favour of the upstream pymacaroons package (LP #1590813). Autopkgtests passed except cleanup; released in snapcraft 2.12. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#584, replacing the local pymacaroons copy with the proper Python package. Unit, integration, and snap tests passed; only cleanup failed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after passing unit, integration, and snap tests. Replaced a local pymacaroons copy with the official Python package. Approved by @come-maiz despite a cleanup test failure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after passing unit, integration, and snap tests. Replaced a local copy with the official pymacaroons package, resolving LP: #1590813. Merged by @come-maiz despite a cleanup failure. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
snapcraft (launchpad)#1590813
(confidence 95%)
The PR identifies LP #1590813 as the tracking issue; the fix was released in Snapcraft 2.12.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1590813 snapcraft has a copy of pymacaroons code | snapcraft (launchpad) | closed | Vendored pymacaroons copy removed in favour of the xenial distro package, via ubuntu-core/snapcraft#584 (commit 28b94b375). SRU'd as snapcraft 2.12, verified by elopio and released to xenial-updates; bug closed verification-done. | |
| #5315 build(deps): move pymacaroon to a dev dependency | snapcraft | merged | PR #5315 by mr-cal merged as commit f7ca63a10, moving pymacaroons from runtime dependencies to the dev dependency group; it is now only imported by tests/unit/conftest.py. |