← Back to issue list

The nodejs plugin downloads packages during the build

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1612005
Type
issue
State
closed
Author
~elopio
Labels
—
Created
Updated
Closed

Current evaluation

Closed in 2019 after the maintainer noted the plugin was no longer supported; no closing PR was cited. Earlier pull-phase npm work appeared in snapcore/snapcraft#936.

Resolution: closed stale

Reason: The 2019-01-24 closing comment states only “plugin no longer supported,” indicating decommissioning rather than a documented Launchpad fix. Commit 0497daaac from PR #936 performed related pull-phase installation work but was not cited as the closing resolution.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The build step of the nodejs and gulp plugins involves running npm install. This makes launchpad builds fail, because they only allow downloads during the pull phase: Building assets npm install -g gulp-cli npm ERR! Linux 3.13.0-93-generic npm ERR! argv "/build/snapweb/parts/assets/npm/bin/node" "/build/snapweb/parts/assets/npm/bin/npm" "install" "-g" "gulp-cli" npm ERR! node v4.4.4 npm ERR! npm v2.15.1 npm ERR! code ENOTFOUND npm ERR! errno ENOTFOUND npm ERR! syscall getaddrinfo

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed in 2019 after the maintainer noted the plugin was no longer supported; no closing PR was cited. Earlier pull-phase npm work appeared in snapcore/snapcraft#936.
stealth/space-bunny-alpha — closed stale The download problem was addressed by snapcraft#936 (0497daaac), but LP #1612005 was ultimately closed after the legacy plugin became unsupported.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#762 (commit 0b3283081), moving npm dependency downloads to pull and caching them for offline builds.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#762 (commit 0b3283081): npm dependencies are now fetched during pull, cached for offline builds, and installed with --global.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. The nodejs and gulp plugins executed npm install during the build phase, violating Launchpad restrictions that only permit downloads during the pull phase. Likely abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Closed. The nodejs plugin was modified to run npm install during the pull phase instead of the build phase, resolving Launchpad download failures.

Update history

Date Change
created

Related work

  • Related To: snapcore/snapcraft#762 (confidence 100%)

    Explicitly linked by the maintainer as related gulp-plugin work.

  • Duplicate Of: snapcraft (launchpad)#1618622 (confidence 95%)

    The maintainer stated that the gulp-plugin work was moved to this Launchpad bug.

  • Related To: snapcraft (launchpad)#1616421 (confidence 95%)

    Explicitly identified in the discussion as a related Launchpad bug.

  • Related To: snapcore/snapcraft#936 (confidence 85%)

    Commit 0497daaac moved Node.js installation into the pull phase, matching Launchpad's network boundary.

Related issues

Issue Project State Summary Similarity
#1633298 nodejs plugin never runs install during pull snapcraft (launchpad) closed Bug where the nodejs plugin skipped npm install during pull (builddir check always false) was fixed by merged PR snapcore/snapcraft#936 (commit 0497daaac), which installs dependencies during pull.
71%