← Back to issue list

etcd tree drives snapcraft dump plugin insane

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1615242
Type
issue
State
open
Author
~sabdfl
Labels
craft-6 sources
Created
Updated
Closed
—

Current evaluation

Historical dump-plugin recursion on etcd's directory symlinks was fixed; source copying now preserves links, and the current dump plugin uses cp --no-dereference.

Suggested action: close resolved

Reason: The report provides an exact reproducer, and maintainer ~elopio identified recursive directory links as the cause. Resolving commits 7768cd33b (#1063) and baeec1045 (#1081) made file and source copying preserve directory symlinks; the current dump plugin also runs cp with --no-dereference.

Evaluated by: mr-cal-bot

Impact: 45 Quick Win: 28 Complexity: 30 Confidence: 94 Actionability: 90

Issue body

Managed to get an infinite loop of copying under way with this snapcraft.yaml: name: etcd version: 3.0.6+master # this branch tracks upstream master summary: Distributed key-value store # 79 char long summary description: | Etcd provides a key-value store and is implemented for high availability, using the RAFT algorithm to deal with failover within the etcd cluster. Popular in the Docker community as a shared store of small but important pieces of common data in an application. confinement: devmode # use "strict" to enforce system access only via declared interfaces apps: etcd: command: bin/etcd etcdctl: command: bin/etcdctl parts: etcd: plugin: dump source: . stage: - bin/*

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 45
Quick Win: 28
Complexity: 30
Confidence: 94
Actionability: 90
close resolved Historical dump-plugin recursion on etcd's directory symlinks was fixed; source copying now preserves links, and the current dump plugin uses cp --no-dereference.
stealth/space-bunny-alpha
Impact: 48
Quick Win: 38
Complexity: 15
Confidence: 94
Actionability: 92
close resolved Historical dump-plugin recursion caused by etcd's cyclic directory symlinks is resolved: the current implementation uses cp --no-dereference, and snapcraft_legacy has been removed.
stealth/space-bunny-alpha
Impact: 5
Quick Win: 4
Complexity: 10
Confidence: 96
Actionability: 84
close stale Historical dump-plugin recursion bug caused by source-tree symlinks to ancestors; reproducible and diagnosed in 2016, but dump is absent from current Snapcraft plugin registration.
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 17
Complexity: 40
Confidence: 65
Actionability: 70
keep open dump plugin causes infinite loop when source directory contains symlinks pointing to parent directories
qwen/qwen3.8-27b
Impact: 40
Quick Win: 18
Staleness: 90
Complexity: 55
Confidence: 55
Support Request: 10
needs triage Infinite copy loop in the snapcraft dump plugin when building etcd with source: . and stage: bin/*. Reported 2016, 0 comments, no maintainer response, last activity ~5 years ago; dump plugin still exists in the current craft-parts-based codebase.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 40
Confidence: 90
Support Request: 10
close stale Reports an infinite copy loop in the snapcraft dump plugin when building etcd. Open for nearly a decade with no maintainer response or activity for over five years.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 30
Confidence: 90
Support Request: 5
close stale Reports an infinite copy loop in snapcraft's dump plugin when using source: . with etcd. No maintainer response or comments. Open for over nine years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 30
Confidence: 90
Support Request: 10
close stale Report of an infinite copy loop in the snapcraft dump plugin when building etcd. Unaddressed for over 9 years with no maintainer interaction or updates.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#1063 (confidence 94%)

    Commit 7768cd33b changed copying so directory symlinks are copied as symlinks.

  • Likely Fixed By: snapcraft#1081 (confidence 94%)

    Commit baeec1045 explicitly updated source handling to preserve directory symlinks.

Related issues

No related issues found above the similarity threshold.