← Back to issue list

tags need to apply to all go packages

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1640184
Type
issue
State
closed
Author
~sergiusens
Labels
plugin
Created
Updated
Closed

Current evaluation

Fixed by merged PR snapcore/snapcraft#888 (commit d817b1dbb): the Go plugin now honors go-buildtags for every package, including when go-packages is defined.

Resolution: closed resolved

Reason: PR #888 was merged as commit d817b1dbb and the maintainer linked it when closing the issue. It changed the Go plugin to always respect go-buildtags.

Evaluated by: mr-cal-bot

No scores available.

Issue body

tags are only taken into account when go-packages are not defined.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcore/snapcraft#888 (commit d817b1dbb): the Go plugin now honors go-buildtags for every package, including when go-packages is defined.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #888 (commit d817b1dbb), making go-buildtags always respected instead of only when go-packages is undefined; issue closed by maintainer ~sergiusens citing that PR.
stealth/space-bunny-alpha — closed stale Closed as abandoned after years of inactivity; no fix or resolving PR or commit was found.
qwen/qwen3.6-35b-a3b — — Abandoned and closed without resolution. The reported issue that tags only apply when go-packages are undefined was never addressed or fixed.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The issue reported tags only apply when go-packages are undefined, but received no discussion or fix. Likely abandoned or superseded by updated plugin logic.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#888 (confidence 99%)

    Merged fix titled "Always respect go-buildtags"; resolving commit d817b1dbb.

Related issues

Issue Project State Summary Similarity
#733 Add the go-buildtags property to the go plugin snapcraft merged Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin, implementing LP #1609623 in commit 59d4acf8a.
75%
#1609623 go plugin has no build tags snapcraft (launchpad) closed Added Go build-tag support via the go-buildtags property in snapcraft PR #733 (commit 59d4acf8a), later refined by PR #888.
75%