unittests are not passing in armhf
Metadata
Current evaluation
Architecture-hardcoded unit tests (pluginhandler IsDirty and commands push) were made arch-agnostic by canonical/snapcraft#945, commit 073332b9b "tests: fix unittests for armhf", closing the armhf autopkgtest failures.
Resolution: closed resolved
Reason: Maintainer ~elopio commented that PR #945 is the new #917; commit 073332b9b ('tests: fix unittests for armhf (#945)') landed in snapcraft and the Launchpad bug was closed as fixed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There are 6 tests that assume they are not running in armhf.
The unittests should be agnostic, and run the same on all architectures.
======================================================================
FAIL: test_build_is_dirty_from_project (snapcraft.tests.test_pluginhandler.IsDirtyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
return func(*args, **keywargs)
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_pluginhandler.py", line 1530, in test_build_is_dirty_from_project
'Expected build step to be dirty')
AssertionError: False is not true : Expected build step to be dirty
======================================================================
FAIL: test_pull_is_dirty_from_project (snapcraft.tests.test_pluginhandler.IsDirtyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
return func(*args, **keywargs)
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_pluginhandler.py", line 1579, in test_pull_is_dirty_from_project
'Expected pull step to be dirty')
AssertionError: False is not true : Expected pull step to be dirty
======================================================================
FAIL: test_push_a_snap (snapcraft.tests.test_commands_push.PushCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_commands_push.py", line 82, in test_push_a_snap
self.fake_logger.output)
AssertionError: "Uploading my-snap-name_0.1_amd64.snap.\nRevision 9 of 'my-snap-name' created." not found in "Created snapcraft.yaml.\nEdit the file to your liking or run `snapcraft` to get started\nPreparing to pull my-part \nPulling my-part \nPreparing to build my-part \nBuilding my-part \nStaging my-part \nPriming my-part \nSnapped my-snap-name_0.1_armhf.snap\nUploading my-snap-name_0.1_armhf.snap.\nRevision 9 of 'my-snap-name' created.\n"
======================================================================
FAIL: test_push_and_release_a_snap (snapcraft.tests.test_commands_push.PushCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_commands_push.py", line 196, in test_push_and_release_a_snap
self.fake_logger.output)
AssertionError: "Uploading my-snap-name_0.1_amd64.snap.\nRevision 9 of 'my-snap-name' created." not found in "Created snapcraft.yaml.\nEdit the file to your liking or run `snapcraft` to get started\nPreparing to pull my-part \nPulling my-part \nPreparing to build my-part \nBuilding my-part \nStaging my-part \nPriming my-part \nSnapped my-snap-name_0.1_armhf.snap\nUploading my-snap-name_0.1_armhf.snap.\nRevision 9 of 'my-snap-name' created.\nThe 'beta' channel is now open.\n"
======================================================================
FAIL: test_push_and_release_a_snap_to_N_channels (snapcraft.tests.test_commands_push.PushCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_commands_push.py", line 245, in test_push_and_release_a_snap_to_N_channels
self.fake_logger.output)
AssertionError: "Uploading my-snap-name_0.1_amd64.snap.\nRevision 9 of 'my-snap-name' created." not found in "Created snapcraft.yaml.\nEdit the file to your liking or run `snapcraft` to get started\nPreparing to pull my-part \nPulling my-part \nPreparing to build my-part \nBuilding my-part \nStaging my-part \nPriming my-part \nSnapped my-snap-name_0.1_armhf.snap\nUploading my-snap-name_0.1_armhf.snap.\nRevision 9 of 'my-snap-name' created.\nThe 'beta,edge,candidate' channel is now open.\n"
======================================================================
FAIL: test_upload_raises_deprecation_warning (snapcraft.tests.test_commands_push.PushCommandTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.sdXxxA/build.Jjd/snapcraft/snapcraft/tests/test_commands_push.py", line 150, in test_upload_raises_deprecation_warning
self.fake_logger.output)
AssertionError: "Uploading my-snap-name_0.1_amd64.snap.\nRevision 9 of 'my-snap-name' created." not found in "Created snapcraft.yaml.\nEdit the file to your liking or run `snapcraft` to get started\nPreparing to pull my-part \nPulling my-part \nPreparing to build my-part \nBuilding my-part \nStaging my-part \nPriming my-part \nSnapped my-snap-name_0.1_armhf.snap\nDEPRECATED: Use `push` instead of `upload`\nUploading my-snap-name_0.1_armhf.snap.\nRevision 9 of 'my-snap-name' created.\n"
----------------------------------------------------------------------
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Architecture-hardcoded unit tests (pluginhandler IsDirty and commands push) were made arch-agnostic by canonical/snapcraft#945, commit 073332b9b "tests: fix unittests for armhf", closing the armhf autopkgtest failures. | |
| stealth/space-bunny-alpha | — | closed resolved | Architecture-dependent unit tests were fixed by merged PR canonical/snapcraft#945 in commit 073332b9b, making the suite architecture-agnostic. | |
| stealth/space-bunny-alpha | — | closed resolved | Armhf unit-test failures were fixed in merged PR #945 (commit 073332b9b), making the affected tests architecture-agnostic. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution or comments, likely abandoned or superseded. The six failing armhf tests required architecture-agnostic updates to pass across all platforms. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without comments or resolution. The six armhf-specific test failures were likely fixed in a subsequent commit or the issue was abandoned due to inactivity. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#945
(confidence 96%)
Commit 073332b9b titled 'tests: fix unittests for armhf (#945)' matches the reported failures
-
Superseded By:
canonical/snapcraft#945
(confidence 92%)
Per maintainer comment, #945 replaces the earlier #917
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #945 Fix unittests in armhf | snapcraft | merged | Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf. | |
| #1671192 kernel unit tests fail in armhf and arm64 | snapcraft (launchpad) | closed | Kernel plugin unit tests failed on armhf/arm64 after snapcore/snapcraft#1148 added DTB build/install args only for ARM; fixed by snapcore/snapcraft#1178 (commit b2a31b957), which made the tests architecture-independent. | |
| #1649899 integration tests fail in armhf | snapcraft (launchpad) | closed | Armhf integration tests were fixed and re-enabled by merged PR snapcore/snapcraft#971 (commit a725e69da). | |
| #1589752 unit tests in IsDirtyTestCase fail when executed in a platform that's not amd64 | snapcraft (launchpad) | closed | Fixed by upstream PR ubuntu-core/snapcraft#553 (commit 393c4e201), which made IsDirtyTestCase architecture-agnostic; released in snapcraft 2.11 to xenial -updates, SRU verified. | |
| #917 Fix unittests in armhf | snapcraft | closed | armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b. | |
| #1650458 snaps tests fail in armhf | snapcraft (launchpad) | closed | Armhf snap test builds were fixed by snapcore/snapcraft#990, merged as f467e55bc; installation testing remained deferred because runners used LXC. |