← Back to issue list

Fix unittests in armhf

View original Github issue

Metadata

Project
snapcraft
Number
#917
Type
pull request
State
closed
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b.

Resolution: closed superseded

Reason: come-maiz closed the PR on 2016-12-05 stating "Closed in favor of #945, to split the integration and snaps tests to separate branches." PR #945 carried the armhf unit-test fixes and was merged as commit 073332b9b, making the unit tests architecture-agnostic.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1643029

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #945 to separate armhf test fixes by test type; #945 subsequently merged as commit 073332b9b.
qwen/qwen3.6-35b-a3b — — Closed in favor of PR #945 to split integration and snaps tests into separate branches. Original changes addressed armhf unittest failures after test machine configuration updates.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by PR #945. The armhf unittest fixes were split into separate branches for integration and snaps tests in the referenced pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#945 (confidence 99%)

    Maintainer explicitly closed this PR in favor of #945, which merged as commit 073332b9b with the armhf unit-test fixes.

Related issues

Issue Project State Summary Similarity
#945 Fix unittests in armhf snapcraft merged Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf.
86%
#971 tests: fix integration tests in armhf snapcraft merged Merged PR #971 as commit a725e69da, fixing armhf integration-test setup with architecture-specific test configuration.
79%
#990 tests: fix snaps tests in armhf snapcraft merged Merged PR #990 as commit f467e55bc, correcting armhf failures in snap tests across 11 files and closing Launchpad bug #1650458.
77%
#1649899 integration tests fail in armhf snapcraft (launchpad) closed Armhf integration tests were fixed and re-enabled by merged PR snapcore/snapcraft#971 (commit a725e69da).
75%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged #1595 (8db14753d), fixing armhf snapd integration-test skips by checking self.deb_arch only after the parent setUp initialized it.
73%
#1430 tests: enable the snaps installation in armhf snapcraft closed PR #1430 was closed unmerged as stale WIP; its attempt to enable snap-installation tests on armhf was abandoned after the change stopped working.
73%
#2520 fix: make integration tests work on ARM Mac runners charmcraft closed ARM-Mac test fixes were abandoned: PR #2520 closed unmerged, and commit f8b267e reverted the faulty changes after review.
73%
#145 fix: fix tests on arm64 craft-archives merged Merged as commit 8459563, fixing arm64 test expectations after prerequisite #143 and resolving #144.
72%
#1643029 unittests are not passing in armhf snapcraft (launchpad) closed Architecture-hardcoded unit tests (pluginhandler IsDirty and commands push) were made arch-agnostic by canonical/snapcraft#945, commit 073332b9b "tests: fix unittests for armhf", closing the armhf autopkgtest failures.
71%
#1119 tests: skip the tests that can't be run in arm64 snapcraft closed Closed unmerged; PR #1145 superseded it and was merged as b24e70721, changing unsupported arm64 tests to expect failure instead of being skipped.
70%