State tests need to be reorganized
Metadata
Current evaluation
State-specific unit tests were reorganized via snapcore/snapcraft PR #1019, cited by the maintainer as the fix before issue #1652136 was closed.
Resolution: closed resolved
Reason: The maintainer explicitly linked snapcore/snapcraft PR #1019 as the fix. That PR reorganized state tests into dedicated subdirectories, resolving the unmanageable test-layout concern.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Most of snapcraft's unit tests are located in snapcraft/tests/. This makes for a large, unmanageable directory. The state-specific tests really belong in their own test subdirectory (especially considering that the code is laid out that way). Reorganizing the tests in this manner will lead to a more manageable unit test suite.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | State-specific unit tests were reorganized via snapcore/snapcraft PR #1019, cited by the maintainer as the fix before issue #1652136 was closed. | |
| stealth/space-bunny-alpha | — | closed resolved | Maintainer cleanup request to move state-specific unit tests into their own subdirectory. Resolved by snapcore/snapcraft PR #1019, merged as commit 9abdc0dd3 ("tests: reorganize state tests into subdirectory"). | |
| stealth/space-bunny-alpha | — | closed resolved | Test-suite cleanup request closed by merged PR snapcore/snapcraft#1019 (commit 9abdc0dd3), which moved six state-specific unit test files from snapcraft/tests/ into a dedicated subdirectory matching the code layout, with no production changes. | |
| stealth/space-bunny-alpha | — | closed resolved | State tests were reorganized into a dedicated subdirectory by merged PR canonical/snapcraft#1019, commit 9abdc0dd3. | |
| qwen/qwen3.6-35b-a3b | — | — | Reorganizing unit tests into state-specific subdirectories was closed without implementation. No pull requests were created, indicating the change was abandoned or superseded by later refactoring. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The proposed test reorganization was abandoned or superseded by later refactoring, as no pull requests or resolution details were recorded. | |
| qwen/qwen3.6-35b-a3b | — | — | Request to reorganize unit tests into state-specific subdirectories was closed without implementation. Zero comments and no linked pull requests indicate the change was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. The proposal to reorganize state-specific tests into a dedicated subdirectory was abandoned, with no implementation or follow-up activity. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#1019
(confidence 100%)
The maintainer cited PR #1019 as the direct fix for this issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #1651908 Command tests need to be reorganized. | snapcraft (launchpad) | closed | Command tests were moved into a dedicated subdirectory by snapcore/snapcraft PR #1015, resolving Launchpad #1651908. |