Command tests need to be reorganized.
Metadata
Current evaluation
Command tests were moved into a dedicated subdirectory by snapcore/snapcraft PR #1015, resolving Launchpad #1651908.
Resolution: closed resolved
Reason: Resolved by snapcore/snapcraft PR #1015 in commit 90b63c944, titled “tests: reorganize command tests into subdirectory.” The issue’s closing comment explicitly links the PR.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Most of snapcraft's unit tests are located in snapcraft/tests/. This makes for a large, unmanageable directory. The command-specific tests make for a large number of these files, and they really belong in their own test subdirectory. Reorganizing the tests in this manner will lead to a more manageable unit test suite.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Command tests were moved into a dedicated subdirectory by snapcore/snapcraft PR #1015, resolving Launchpad #1651908. | |
| stealth/space-bunny-alpha | — | closed resolved | Closed by merged PR snapcraft#1015 (commit 90b63c94), moving command unit tests from snapcraft/tests/ into a dedicated subdirectory as requested by maintainer kyrofa; tracked as LP #1651908. | |
| stealth/space-bunny-alpha | — | closed resolved | Command unit tests were reorganized into a dedicated tests/commands subdirectory by merged PR #1015 (90b63c944), making the suite more manageable. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The test reorganization was abandoned or superseded by later refactoring, as no resolution or linked pull request was documented. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and abandoned. The proposed test reorganization was not implemented, likely superseded by later codebase refactoring, with no comments or resolution recorded. | |
| qwen/qwen3.6-35b-a3b | — | — | Command test reorganization was closed without implementation or linked pull requests. The request was abandoned, leaving the test directory structure unchanged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Proposed reorganization of command-specific unit tests into a dedicated subdirectory was closed without action or discussion. The enhancement was abandoned. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#1015
(confidence 100%)
The linked PR reorganized command-specific tests and was recorded in commit 90b63c944.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #1015 tests: reorganize command tests into subdirectory. | snapcraft | merged | Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908. | |
| #1652136 State tests need to be reorganized | snapcraft (launchpad) | closed | State-specific unit tests were reorganized via snapcore/snapcraft PR #1019, cited by the maintainer as the fix before issue #1652136 was closed. | |
| #1569401 example tests are failing because they call the old snappy command | snapcraft (launchpad) | closed | Example tests were updated from snappy to snap, fixing Launchpad #1569401 through merged PR ubuntu-core/snapcraft#439 (commit bce446559). |