Plugin tests need to be reorganized
Metadata
Current evaluation
Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903.
Resolution: closed resolved
Reason: Maintainer kyrofa commented "Fix: https://github.com/snapcore/snapcraft/pull/1014", and PR #1014 was merged as commit d97c00e8f ("tests: reorganize plugin tests into subdirectory"), which relocated plugin unit tests under tests/unit/plugins/.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Most of snapcraft's unit tests are located in snapcraft/tests/. This makes for a large, unmanageable directory. The plugin-specific tests make for a large number of these files, and they really belong in their own test subdirectory. Reorganizing the tests in this manner will lead to a more manageable unit test suite.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| stealth/space-bunny-alpha | — | closed resolved | Closed as fixed: plugin unit tests moved out of the monolithic tests dir into their own subdirectory by merged PR #1014 (commit d97c00e8f), resolving Launchpad bug #1651903. | |
| stealth/space-bunny-alpha | — | closed resolved | Plugin unit tests were moved into a dedicated subdirectory by merged PR canonical/snapcraft#1014 (d97c00e8f). | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without a linked pull request or explicit resolution. The proposed plugin test reorganization appears abandoned or implicitly resolved through subsequent codebase refactoring. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned. The proposed reorganization of plugin tests into a dedicated subdirectory was not implemented, and the issue was closed without discussion or follow-up. | |
| qwen/qwen3.6-35b-a3b | — | — | Requesting plugin tests be moved to a dedicated subdirectory was closed without implementation. No pull requests were created, indicating the proposal was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Requesting plugin tests be moved to a dedicated subdirectory was closed without discussion or action. No pull request was opened, and the test structure remains unchanged, indicating the suggestion was abandoned. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#1014
(confidence 99%)
Merged PR cited in the closing comment; commit d97c00e8f reorganized plugin tests into a subdirectory.
-
Related To:
snapcraft#1948
(confidence 70%)
Follow-up commit 55ad11ccc 'tests: move test files out of the snapcraft dir' continued the same test-suite reorganization effort.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1014 tests: reorganize plugin tests into subdirectory. | snapcraft | merged | Merged #1014 as d97c00e8f, moving plugin unit tests into a dedicated subdirectory to make the suite manageable and resolve LP #1651903. | |
| #1651908 Command tests need to be reorganized. | snapcraft (launchpad) | closed | Command tests were moved into a dedicated subdirectory by snapcore/snapcraft PR #1015, resolving Launchpad #1651908. | |
| #1652136 State tests need to be reorganized | snapcraft (launchpad) | closed | State-specific unit tests were reorganized via snapcore/snapcraft PR #1019, cited by the maintainer as the fix before issue #1652136 was closed. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1623289 Unify python plugin tests | snapcraft (launchpad) | closed | Launchpad task to remove duplicated python2/python3 plugin tests was closed by maintainer sergiusens pointing to snapcore/snapcraft PR #793, which unified the test coverage. | |
| #2716 tests: completely mock subversion tests | snapcraft | merged | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| #1015 tests: reorganize command tests into subdirectory. | snapcraft | merged | Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908. | |
| #133 Added a test to check that the snapcraft files are ignored. | snapcraft | closed | Superseded by merged PR canonical/snapcraft#137, which added the Snapcraft-file exclusion regression test and cleaned up base-plugin tests. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. |