← Back to issue list

kernel plugin: the modprobe output parsing is wrong

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1675029
Type
issue
State
closed
Author
~sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Fixed by merged PR snapcraft/snapcraft#1208 (commit 6c8d85ee3), correcting kernel-plugin modprobe parsing to use the module path from the second output item.

Resolution: closed resolved

Reason: PR snapcraft/snapcraft#1208 was merged as commit 6c8d85ee3 and fixed the parser so trailing module arguments are not mistaken for the module path.

Evaluated by: mr-cal-bot

No scores available.

Issue body

For this output: $ modprobe --show-depends -n vmwgfx insmod /lib/modules/4.10.0-13-generic/kernel/drivers/video/fbdev/core/sysimgblt.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/video/fbdev/core/sysfillrect.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/video/fbdev/core/syscopyarea.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/video/fbdev/core/fb_sys_fops.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/gpu/drm/drm.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/gpu/drm/drm_kms_helper.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/gpu/drm/ttm/ttm.ko insmod /lib/modules/4.10.0-13-generic/kernel/drivers/gpu/drm/vmwgfx/vmwgfx.ko enable_fbdev=1 We always capture the last item, on the last line you can see why this is a problem.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcraft/snapcraft#1208 (commit 6c8d85ee3), correcting kernel-plugin modprobe parsing to use the module path from the second output item.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcraft#1208 (commit 6c8d85ee3), changing the kernel plugin to use the module path from the second modprobe output item.
stealth/space-bunny-alpha — closed stale Incorrect modprobe dependency parsing was reported, but the item closed with no documented fix, patch, or resolving PR (Launchpad LP#1675029).
qwen/qwen3.6-35b-a3b — — Closed without resolution. The kernel plugin modprobe output parser incorrectly captured only the last dependency line. No fix or patch was applied.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The kernel plugin incorrectly parsed modprobe output, capturing only the last dependency line instead of all modules.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft/snapcraft#1208 (confidence 100%)

    The PR was linked from the issue and merged as resolving commit 6c8d85ee3.

Related issues

Issue Project State Summary Similarity
#1208 kernel plugin: fix modprobe output parsing. snapcraft merged Merged in #1208 via commit 6c8d85ee3, fixing kernel-plugin modprobe parsing to take the module path from the second output item and addressing LP #1675029.
83%
#6418 core26: kernel plugin fails to run snapcraft closed Fixed by merged PR canonical/snapcraft#6425 (commit be405aad6), updating the kernel plugin to handle modules packaged under usr/lib on usrmerged core26 systems.
74%
#1759592 kernel build fails for lack of modprobe snapcraft (launchpad) closed Kernel builds on Launchpad failed because modprobe was missing. Fixed by snapcore/snapcraft PR #2041, merged as commit 327552751, adding kmod to the kernel plugin's build-packages (plus /sbin on PATH); LP bug closed as fixed.
74%
#1115 kernel plugin: fix kernel snap layout snapcraft merged Merged via commit 86017cdef: kernel plugin now places modules/ and firmware/ at the top level of prime/ for kernel snaps, plus corrected required build packages; unit and manual tests updated per review.
73%
#1606903 kernel plugin: can't snap a kernel using launchpad snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#903 (commit 603948e1d), allowing Store part downloads without snapcraft login and resolving Launchpad kernel builds.
73%