← Back to issue list

node project labeled as -dirty

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1768668
Type
issue
State
closed
Author
~heroku-jdxcode
Labels
—
Created
Updated
Closed

Current evaluation

Snapcraft stopped producing “-dirty” versions after source-management fixes; the reporter confirmed the behavior was gone, but no exact fixing PR was recorded.

Resolution: closed resolved

Reason: The reporter confirmed on 2018-08-22 that the behavior no longer occurred. Maintainer Sergiusens stated on 2019-02-18 that source-management fixes could have resolved it.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Current behavior: The builds for the heroku cli are being labeled as "-dirty" from builds.snapcraft.io: https://build.snapcraft.io/user/heroku/cli/206577 Expected behavior: Should not have "-dirty" My understanding is "-dirty" means there are working tree changes before building the snap in git—which should never be the case on builds.snapcraft.io.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Snapcraft stopped producing “-dirty” versions after source-management fixes; the reporter confirmed the behavior was gone, but no exact fixing PR was recorded.
stealth/space-bunny-alpha — closed resolved Resolved after source-management fixes stopped build-time VCS operations from leaving projects dirty; maintainers confirmed the problem was gone.
stealth/space-bunny-alpha — closed stale Closed without explanation after roughly 292 days of inactivity; the matching Launchpad report was also closed without comments or a documented fix.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. The incorrect dirty build suffix indicating uncommitted git changes was never addressed and the report was abandoned.
qwen/qwen3.6-35b-a3b — — Reporting a "-dirty" label on Heroku CLI snap builds was closed without resolution or comments. No fix was provided, indicating the report was abandoned or stale.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. The reported snapcraft.io build labeling bug ("-dirty" suffix) was not addressed, indicating the issue was abandoned or marked stale.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. The report noted snap builds incorrectly labeled with a -dirty suffix, indicating uncommitted git changes. No fix or discussion was provided.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#923 (confidence 40%)

    Commit 4c35acef2 moved source management into the core, matching the cited fix area, but the issue did not explicitly link this PR.

Related issues

Issue Project State Summary Similarity
#2289 local source: only filter out snapcraft artifacts snapcraft closed Closed unmerged; #2294 superseded its approach with commit 089629e17, removing --dirty from git describe to work around LP #1662388.
75%