← Back to issue list

pluginhandler: source management moved to the core

View original Github issue

Metadata

Project
snapcraft
Number
#923
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #923 as commit 4c35acef2, moving part source management from plugins into Snapcraft core and incorporating review fixes and property-handling refactors.

Resolution: closed resolved

Reason: PR #923 was approved and merged into Snapcraft. Commit 4c35acef2 centralized source management in PluginHandler and incorporated the reviewed IPFS and pull/build property fixes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1621601 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #923 as commit 4c35acef2, moving part source management from plugins into Snapcraft core and incorporating review fixes and property-handling refactors.
stealth/space-bunny-alpha — closed resolved Merged PR #923 as 4c35acef2, centralizing source management in Snapcraft core and addressing review feedback, including IPFS fixes and pull/build property refactors.
qwen/qwen3.6-35b-a3b — — Merged. Moved plugin source management to the core across 40 files (+1183/-1043 lines). Addressed reviewer feedback, including IPFS fixes and refactoring pull/build property methods. Approved by two reviewers and integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that moved source management from the pluginhandler to the core. Converted pull and build property methods to class methods, resolved IPFS issues, and incorporated reviewer feedback on property handling.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#954 pluginhandler: convert to package snapcraft merged Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change.
72%
#3023 pluginhandler: move attributes to PluginHandler snapcraft merged Merged in snapcraft#3023 (bb268fada), centralizing duplicate plugin attributes in PluginHandler and reducing reliance on mutable plugin-set state.
71%