← Back to issue list

Do not inject snapcraft with no revision if it is the same

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1779945
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Fixed by merged PR snapcore/snapcraft#2196, improving build-provider Snapcraft injection logic in commit d9a477ea5.

Resolution: closed resolved

Reason: The linked resolution was merged as commit d9a477ea5 ("build providers: better injection logic"), addressing unnecessary Snapcraft injection when host and VM revisions were already equivalent.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When installing snaps from the store we get a snap-revision assertion which is enough to compare versions of snapcraft on the host and in the VM, but given --dangerous installs we do not have this facility. Come up with a fast comparison mechanism to know if we need the latest snapcraft or not.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcore/snapcraft#2196, improving build-provider Snapcraft injection logic in commit d9a477ea5.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #2196, which improved build-provider Snapcraft injection logic (commit d9a477ea5).
stealth/space-bunny-alpha — closed stale Closed without a recorded fix, PR, or explanation; the matching Launchpad report snapcraft#1893850 remains open.
qwen/qwen3.6-35b-a3b — — Closed without implementation or discussion. The proposed fast comparison mechanism for snapcraft version injection was abandoned, likely superseded by updated build tooling.
qwen/qwen3.6-35b-a3b — — Closed without linked PRs or comments. The request to implement a fast snapcraft version comparison mechanism was abandoned or superseded by newer build tooling.
qwen/qwen3.6-35b-a3b — — Closed without comments or linked resolution. The request for a fast snapcraft version comparison for --dangerous installs was abandoned or resolved internally.
qwen3.6-35b-a3b-mtp-q6 — — Closed without comments or linked resolution. Likely abandoned due to age and lack of activity. No fix or merge details provided.

Update history

Date Change
created

Related work

Related issues

Issue Project State Summary Similarity
#1782777 Improve installation/injection logic for snapcraft (and core) snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft PR #2196 in commit d9a477ea5, improving build-provider installation and snap injection logic.
76%