← Back to issue list

Improve installation/injection logic for snapcraft (and core)

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1782777
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Fixed by merged snapcore/snapcraft PR #2196 in commit d9a477ea5, improving build-provider installation and snap injection logic.

Resolution: closed resolved

Reason: The maintainer linked GitHub PR #2196 as the resolution; repository history records it as merged as commit d9a477ea5.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Create a registry of installations to quickly determine if a new injection is required. Operationalize each action required for every snap.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged snapcore/snapcraft PR #2196 in commit d9a477ea5, improving build-provider installation and snap injection logic.
stealth/space-bunny-alpha — closed resolved Fixed Snapcraft installation/injection handling by merging PR #2196 as commit d9a477ea5, improving build-provider injection logic across 12 files.
stealth/space-bunny-alpha — closed stale Closed without a documented resolution or maintainer explanation. Later snap-injection work addressed related logic, but no direct fix is linked.
qwen/qwen3.6-35b-a3b — — Closed with no comments or resolution. Likely abandoned or superseded by later snapcraft updates. No fix or merge was tracked.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposal to create an installation registry for snapcraft injection logic was abandoned or superseded by later build system updates.
qwen/qwen3.6-35b-a3b — — Closed without implementation or discussion. The installation registry proposal for snapcraft was abandoned after over two years of inactivity.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned or superseded. Closed without comments, resolution, or merge details after eight years of inactivity. The proposed registry and operationalization logic was never implemented.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2196 (confidence 100%)

    The PR was explicitly cited in the issue and merged as the injection-logic fix.

Related issues

Issue Project State Summary Similarity
#1782778 Improve installation/injection logic for snapcraft (and core) snapcraft (launchpad) closed Installation and host-injection logic was resolved in canonical/craft-providers PR #45, merged as commit 3573b67 under CRAFT-253.
89%
#1779945 Do not inject snapcraft with no revision if it is the same snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#2196, improving build-provider Snapcraft injection logic in commit d9a477ea5.
76%
#2507 build providers: improve handling in snap logic snapcraft merged Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise.
76%
#4084 providers: inject current snapcraft snap into instances snapcraft merged Merged PR #4084 as commit b852f9ac8, injecting the current Snapcraft snap into provider instances so parallel-installed instances can build core22 snaps.
74%
#1779137 build provider support to inject snaps on the host snapcraft (launchpad) closed Build providers gained host-snap injection when Snapcraft runs from a snap; fixed by merged snapcore/snapcraft#2174 (commit 283ab0bb8).
74%
#1820864 Clean up and snapd robustness for snap injection snapcraft (launchpad) closed Snap injection warnings and snapd startup-order robustness were fixed by snapcore/snapcraft#2507, merged as commit 841b41fa3.
74%
#45 actions: introduce helpers to install & inject snaps (CRAFT-253) craft-providers merged PR #45 (commit 5e8109c, merged via 3573b67) added snap_installer.install_from_store() and inject_from_host() helpers plus installed_snap/core20_lxd_instance test fixtures, with unit and integration tests.
73%
#2174 build_providers: inject snaps when running from a snap snapcraft merged Merged PR #2174 (commit 283ab0bb8) to inject host Snapcraft and base snaps when running from the snapcraft snap, while non-snap runs install them from the store.
72%
#2773 build providers: inject snapd snap for latest feature availability snapcraft merged Merged PR #2773 in commit 3740c61bc, replacing injected core snaps with the smaller snapd snap for current build features without requiring core18.
70%