← Back to issue list

add tests for manifest.yaml

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1790026
Type
issue
State
closed
Author
~sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Manifest verification coverage was added by merged snapcore/snapcraft#2235 (commit 78c837273), building the snap and running it through click-review.

Resolution: closed resolved

Reason: The request was resolved by snapcore/snapcraft#2235, merged as commit 78c837273, which added manifest-generation integration tests using click-review.

Evaluated by: mr-cal-bot

No scores available.

Issue body

add manifest verification through click-review

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Manifest verification coverage was added by merged snapcore/snapcraft#2235 (commit 78c837273), building the snap and running it through click-review.
stealth/space-bunny-alpha — closed resolved Manifest.yaml test coverage request closed by merged PR snapcore/snapcraft#2235 (commit 78c837273), which extended manifest-generation integration tests to build the snap and run it through click-review tools.
stealth/space-bunny-alpha — closed stale Abandoned and closed without a documented implementation; no manifest.yaml test changes or click-review integration could be identified.
stealth/space-bunny-alpha — closed stale Closed without a documented resolution; no linked PR or commit was found for the requested manifest.yaml tests.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to add manifest verification via click-review received no comments or follow-up, indicating the task was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation of manifest verification via click-review, likely abandoned.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2235 (confidence 99%)

    The maintainer linked this merged PR as the implementation of the requested manifest verification tests.

Related issues

Issue Project State Summary Similarity
#2234 tests: cover manifest generation with review-tools snapcraft closed Superseded by snapcore/snapcraft#2235, which merged the same manifest-generation integration-test coverage in commit 78c837273.
79%
#2235 tests: cover manifest generation with review-tools snapcraft merged PR merged into master: manifest-generation spread tests extended to actually build a snap and run review-tools.snap-review on it (LP #1790026); the review-tools step survives today in tests/spread/_common/manifest-creation.
75%