tests: cover manifest generation with review-tools
Metadata
Current evaluation
Merged into master. Added integration tests for manifest generation using review-tools and a store push test. Code coverage remained stable at 90.72%.
Suggested action: —
No scores available.
Issue body
Make the integration tests for manifest generation go all the way
to creating a snap and run them through the review tools.
Also add a store test with a snap that contains a manifest to push
to the store as an additional measure.
LP: #1790026
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Added integration tests for manifest generation using review-tools and a store push test. Code coverage remained stable at 90.72%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Added integration tests for manifest generation using review-tools and a store test. Code coverage remained unchanged at 90.72%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Added integration tests for manifest generation using review-tools and a store push test. Codecov reported no coverage impact upon merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2235 tests: cover manifest generation with review-tools | snapcraft | merged | Merged into master. Extends integration tests to validate manifest generation by building a snap and running it through review tools. Approved by reviewer, passed CI, and increased coverage by less than 0.01%. | |
| #956 tests: idempotent store installs. | snapcraft | merged | Merged into master after single reviewer approval. Implements idempotent store installs for tests across three files. Codecov reports a 1.18% coverage decrease upon integration. |