tests: cover manifest generation with review-tools
Metadata
Current evaluation
Superseded by snapcore/snapcraft#2235, which merged the same manifest-generation integration-test coverage in commit 78c837273.
Resolution: closed superseded
Reason: PR #2234 was closed because #2235 replaced it with the same test work. PR #2235 merged as commit 78c837273.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Make the integration tests for manifest generation go all the way
to creating a snap and run them through the review tools.
Also add a store test with a snap that contains a manifest to push
to the store as an additional measure.
LP: #1790026
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by snapcore/snapcraft#2235, which merged the same manifest-generation integration-test coverage in commit 78c837273. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #2235, which merged the same manifest-generation test work into master in commit 78c837273. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Added integration tests for manifest generation using review-tools and a store push test. Code coverage remained stable at 90.72%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Added integration tests for manifest generation using review-tools and a store test. Code coverage remained unchanged at 90.72%. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcore/snapcraft#2235
(confidence 100%)
Merged the equivalent manifest-generation review-tools test coverage in commit 78c837273.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2235 tests: cover manifest generation with review-tools | snapcraft | merged | PR merged into master: manifest-generation spread tests extended to actually build a snap and run review-tools.snap-review on it (LP #1790026); the review-tools step survives today in tests/spread/_common/manifest-creation. | |
| #1790026 add tests for manifest.yaml | snapcraft (launchpad) | closed | Manifest verification coverage was added by merged snapcore/snapcraft#2235 (commit 78c837273), building the snap and running it through click-review. |