← Back to issue list

Improved build provider sanity checks

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1821586
Type
issue
State
closed
Author
~sergiusens
Labels
19.04
Created
Updated
Closed

Current evaluation

Resolved by merged snapcraft#2515 (commit e4a578823), moving build-provider setup and sanity checks into provider implementations.

Resolution: closed resolved

Reason: The linked PR snapcraft#2515 was merged as commit e4a578823 and implemented the requested move from project logic to build-provider classmethods.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Move from project to build provider classmethods to not have everything all over the place

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged snapcraft#2515 (commit e4a578823), moving build-provider setup and sanity checks into provider implementations.
stealth/space-bunny-alpha — closed resolved Resolved by merged snapcraft#2515 (commit e4a578823), moving build-provider setup and sanity checks into provider implementations.
stealth/space-bunny-alpha — closed resolved Build-provider setup and sanity checks were consolidated into provider classmethods in PR #2515 (commit e4a578823), replacing scattered project-level logic.
qwen/qwen3.6-35b-a3b — — Resolved by moving build provider sanity checks to classmethods, centralizing logic and eliminating scattered project-level code. Closed without further discussion.
qwen/qwen3.6-35b-a3b — — Closed after implementing the refactoring, moving build provider sanity checks to classmethods to consolidate project-level logic.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The requested refactoring to move sanity checks to build provider classmethods was not applied, indicating the issue was abandoned or superseded by subsequent changes.
qwen3.6-35b-a3b-mtp-q6 — — Closed. The proposed refactoring to move sanity checks to build provider classmethods was abandoned.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#2515 (confidence 100%)

    Merged commit e4a578823 implements provider-specific setup and sanity checks requested by the issue.

Related issues

Issue Project State Summary Similarity
#2507 build providers: improve handling in snap logic snapcraft merged Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise.
79%
#2515 build providers: support for provider setup snapcraft merged Merged PR #2515 as e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586.
75%
#1779136 build provider support to clean parts snapcraft (launchpad) closed Build-provider support for cleaning selected parts was restored by merged canonical/snapcraft PR #2442 (commit 5546c3aab), without deleting the provider.
72%
#9 providers: add build provider support (CRAFT-28) rockcraft merged Merged build-provider support via commit be6dec45, integrating craft-providers to run builds on LXD. User messages and provider log retrieval were deferred to follow-up work.
70%