godeps plugin: work when GOBIN is set
Metadata
Current evaluation
Merged into master. Resolves LP: #1656118 by fixing the godeps plugin to function correctly when GOBIN is set. Approved by one reviewer, passed CI, and modified two files (+15/-1 lines).
Suggested action: —
No scores available.
Issue body
LP: #1656118
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Resolves LP: #1656118 by fixing the godeps plugin to function correctly when GOBIN is set. Approved by one reviewer, passed CI, and modified two files (+15/-1 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Fixes the godeps plugin to function correctly when the GOBIN environment variable is set, resolving Launchpad bug #1656118. Code coverage passed at 96.36%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. The godeps plugin now correctly handles the GOBIN environment variable, resolving LP #1656118. Code coverage remained stable at 96.36%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1656118 godeps plugin break when GOBIN is set | snapcraft (launchpad) | closed | Closed without a documented fix. The godeps plugin incorrectly installed packages when the GOBIN environment variable was set. | |
| #1179 godeps plugin: add git to build-packages | snapcraft | merged | Merged a patch adding git to the godeps plugin build-packages. The change resolves a missing dependency for go get commands. Approved by one reviewer and merged directly without CI checks. | |
| #1057 godeps plugin: support for go-packages. | snapcraft | merged | Merged into master, adding go-packages support to the godeps plugin to match the go plugin. Approved by a reviewer, passed CI checks, and increased overall code coverage. | |
| #859 Set GOBIN in go plugin build environment. | snapcraft | merged | Merged to resolve #1553215 by setting GOBIN in the go plugin build environment, preventing user variables from redirecting executables incorrectly. Reviewer confirmed the contributor's unsigned CLA is not required. | |
| #2328 godeps plugin: support for bases | snapcraft | merged | Merged. Updated the godeps plugin to prioritize the Go snap and added support for installing golang-go via build-packages on supported bases. Approved, passed CI, and integrated. |