← Back to issue list

godeps plugin: work when GOBIN is set

View original Github issue

Metadata

Project
snapcraft
Number
#1046
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1046 (commit c949d5f3e), fixing the godeps plugin to work when GOBIN is set and resolving LP #1656118.

Resolution: closed resolved

Reason: PR #1046 was merged into master as commit c949d5f3e. The change made the godeps plugin honor GOBIN and addressed LP #1656118.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1656118 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1046 (commit c949d5f3e), fixing the godeps plugin to work when GOBIN is set and resolving LP #1656118.
stealth/space-bunny-alpha — closed resolved Merged PR #1046, commit c949d5f3e, fixed the godeps plugin to work when GOBIN is set, resolving LP #1656118.
stealth/space-bunny-alpha — closed resolved Merged PR #1046 (c949d5f3e) fixed the godeps plugin to work when GOBIN is set, resolving LP #1656118.
qwen/qwen3.6-35b-a3b — — Merged into master. Resolves LP: #1656118 by fixing the godeps plugin to function correctly when GOBIN is set. Approved by one reviewer, passed CI, and modified two files (+15/-1 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Fixes the godeps plugin to function correctly when the GOBIN environment variable is set, resolving Launchpad bug #1656118. Code coverage passed at 96.36%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1656118 godeps plugin break when GOBIN is set snapcraft (launchpad) closed Fixed the godeps plugin’s handling of a preset GOBIN, installing binaries in the correct location via merged PR #1046 (c949d5f3e).
90%
#859 Set GOBIN in go plugin build environment. snapcraft merged Merged PR #859 via commit e44e634f6, setting GOBIN in the Go plugin build environment so user-defined GOBIN no longer redirects executables; fixes the reported interference.
78%
#2328 godeps plugin: support for bases snapcraft merged Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
74%
#1057 godeps plugin: support for go-packages. snapcraft merged Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages.
73%
#1450 godeps plugin recording snapcraft closed Closed with no recorded fix or discussion; the Godeps plugin itself had already been added by merged PR #691 in commit a073503c0.
70%