← Back to issue list

godeps plugin: support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2328
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.

Resolution: closed resolved

Reason: PR #2328 was merged as commit e1393815d. It revamped installation candidates to prefer the Go snap while allowing golang-go through build-packages on supported bases.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Revamp the godeps plugins installation candidates to prefer the go snap from the Snap Store first and provide a mechanism to be able to install a build-packages golang-go instead on the supported bases. LP: #1794784 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
stealth/space-bunny-alpha — closed resolved Merged PR #2328 added base support to the godeps plugin, prioritizing the Go snap and allowing golang-go through build-packages on supported bases.
stealth/space-bunny-alpha — closed resolved Merged PR #2328: updated the godeps plugin to prefer the Go snap and support installing golang-go through build-packages on supported bases; merged as commit e1393815.
qwen/qwen3.6-35b-a3b — — Merged. Updated the godeps plugin to prioritize the Go snap and added support for installing golang-go via build-packages on supported bases. Approved, passed CI, and integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The godeps plugin now prioritizes the Go snap from the Snap Store and supports installing golang-go as a build package on supported bases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2323 go plugin: support for bases snapcraft merged Merged PR #2323 (commit 45a993643): Go plugin revamped to prefer the go snap from the Snap Store and allow installing golang-go build-packages on supported bases, fixing LP: #1794785.
85%
#1794784 Update the godeps plugin to be base aware snapcraft (launchpad) closed Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d.
84%
#1057 godeps plugin: support for go-packages. snapcraft merged Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages.
80%
#691 Add godeps plugin. snapcraft merged Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs.
80%
#1657212 Godeps plugin support to build only needed binaries snapcraft (launchpad) closed Godeps gained go-packages support to build selected binaries via snapcore/snapcraft PR #1057, merged as commit 81f56fd13.
77%
#1179 godeps plugin: add git to build-packages snapcraft merged Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
75%
#1595981 Need a godeps plugin snapcraft (launchpad) closed Godeps plugin support was merged in snapcore/snapcraft#691 via commit a073503c0.
75%
#1046 godeps plugin: work when GOBIN is set snapcraft merged Merged PR #1046 (commit c949d5f3e), fixing the godeps plugin to work when GOBIN is set and resolving LP #1656118.
74%
#1656118 godeps plugin break when GOBIN is set snapcraft (launchpad) closed Fixed the godeps plugin’s handling of a preset GOBIN, installing binaries in the correct location via merged PR #1046 (c949d5f3e).
72%
#1671546 godeps plugin does not installing the git package by itself snapcraft (launchpad) closed Fixed in snapcore/snapcraft#1179, merged as commit 10c46b8ad; the godeps plugin now adds git to build-packages.
70%