← Back to issue list

godeps plugin: support for go-packages.

View original Github issue

Metadata

Project
snapcraft
Number
#1057
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages.

Resolution: closed resolved

Reason: PR #1057 was merged into master as commit 81f56fd13. Its Godeps plugin changes resolved linked Launchpad bug #1657212.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is the on-par support for what is in the go plugin. LP: #1657212 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1057 as commit 81f56fd13, adding go-packages support to the godeps plugin so only specified Go binaries are built, mirroring the go plugin. Fixes LP bug #1657212.
stealth/space-bunny-alpha — closed resolved PR #1057 by sergiusens merged as commit 81f56fd13, adding go-packages support to the godeps plugin, mirroring the existing go plugin behaviour (LP bug #1657212); +292/-13 lines incl. tests.
stealth/space-bunny-alpha — closed resolved Merged as commit 81f56fd13 by maintainer sergiusens, adding go-packages support to the godeps plugin, mirroring the go plugin. Implements LP bug #1657212. Approved with 1 review.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1057 as commit 81f56fd13, adding go-packages support to the godeps plugin.
stealth/space-bunny-alpha — closed resolved Merged PR #1057 added go-packages support to the godeps plugin, matching the go plugin’s selective binary builds.
qwen/qwen3.6-35b-a3b — — Merged into master, adding go-packages support to the godeps plugin to match the go plugin. Approved by a reviewer, passed CI checks, and increased overall code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Adds go-packages support to the godeps plugin, aligning it with the go plugin. Maintainer-authored and passed code coverage checks.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1657212 (confidence 99%)

    Linked Launchpad request to build only selected Godeps binaries, closed by the go-packages support.

Related issues

Issue Project State Summary Similarity
#2328 godeps plugin: support for bases snapcraft merged Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
80%
#691 Add godeps plugin. snapcraft merged Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs.
76%
#1179 godeps plugin: add git to build-packages snapcraft merged Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
74%
#1046 godeps plugin: work when GOBIN is set snapcraft merged Merged PR #1046 (commit c949d5f3e), fixing the godeps plugin to work when GOBIN is set and resolving LP #1656118.
73%
#1657212 Godeps plugin support to build only needed binaries snapcraft (launchpad) closed Godeps gained go-packages support to build selected binaries via snapcore/snapcraft PR #1057, merged as commit 81f56fd13.
73%
#675 Allow godeps to fetch Go dependencies snapcraft closed Unmerged; kyrofa closed it in favour of #691, which added a proper godeps plugin and was merged as commit a073503c0, fixing LP bug #1595981.
71%
#709 Improve the go plugins usability snapcraft merged Merged as 57359d5d0: Go plugins now combine source keywords with go-packages, build selected main packages, and fetch missing dependencies via go get.
70%