← Back to issue list

tests: fix the env vars passed to the docker container in travis

View original Github issue

Metadata

Project
snapcraft
Number
#1125
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1125 in commit 44834f539, fixing Travis CI to pass required environment variables into its Docker test container and resolving LP #1663088.

Resolution: closed resolved

Reason: PR #1125 was merged as commit 44834f539 after approval, correcting environment-variable forwarding to the Travis Docker container.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1663088](https://bugs.launchpad.net/snapcraft/+bug/1663088)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1125 in commit 44834f539, fixing Travis CI to pass required environment variables into its Docker test container and resolving LP #1663088.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1125 via commit 44834f539, fixing environment variables passed to the Travis CI Docker container for LP #1663088.
qwen/qwen3.6-35b-a3b — — Merged a fix correcting environment variables passed to the Docker container in Travis CI tests. Approved by one reviewer, the change updates one file (+4/-2 lines) and resolves Launchpad bug #1663088.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix correcting environment variables passed to Docker containers during Travis CI test runs. The change resolves Launchpad bug #1663088 by updating the test configuration.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1663088 (confidence 100%)

    Launchpad bug reporting missing environment variables in Travis Docker containers; closed by this change.

Related issues

Issue Project State Summary Similarity
#1133 tests: fix the test that was modifying the environment variables snapcraft merged Merged PR #1133 (commit c0b0f9752), fixing a test that leaked PATH/environment-variable changes and guarding against an empty PATH.
74%
#1663088 in travis, the docker container is not getting the environment variables snapcraft (launchpad) closed Fixed Travis CI Docker environment propagation by passing host values with Docker -e arguments in canonical/snapcraft#1125 (commit 44834f539).
72%
#2851 docker: test image builds with Travis CI snapcraft merged Merged PR #2851 (commit 0d161e35e, +26/-0 in .travis.yml) adding a Travis CI job to test Docker image builds. Travis CI itself was later removed in #5073 (commit 5e91afb6a).
71%