tests: fix the TEST_STORE environment variable
Metadata
Current evaluation
Merged in PR #1541 as commit a36d3e053, fixing TEST_STORE handling so tests no longer skip before the empty value is translated to the fake store.
Resolution: closed resolved
Reason: The approved PR was merged as commit a36d3e053. It corrected test skip behavior by handling the empty TEST_STORE value before integration setup assigns the fake-store setting.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
The environment variable is passed to the containers as ''. The setup of integration tests takes care of translating that to 'fake', but some tests are calling the skip before the setup, so weird things happen.
This is a patch for now. The right solution is to not skip any tests, which is almost always doable.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #1541 as commit a36d3e053, fixing TEST_STORE handling so tests no longer skip before the empty value is translated to the fake store. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1541 as commit a36d3e053, fixing TEST_STORE handling so tests do not skip before integration setup converts the empty value to the fake store. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1541 as commit a36d3e053, correcting TEST_STORE handling so tests do not skip before integration setup converts the empty value to the fake store. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the TEST_STORE environment variable. The change prevents skip decorators from running before test setup, resolving unexpected behavior. Approved by three reviewers and squashed prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the TEST_STORE environment variable. The patch prevents skip decorators from triggering before setup translates the empty variable to 'fake'. The branch was squashed and merged after reviewer approval. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5954 tests: fix store tests | snapcraft | merged | PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885). | |
| #2903 tests: fix status test for staging store | snapcraft | merged | Merged PR #2903 as commit 0f0492482, correcting the status test for the staging store. | |
| #802 Add the TEST_STORE environment variable to the travis script | snapcraft | merged | Merged PR #802 in commit 3a32f5937, adding TEST_STORE to Travis so Docker-based tests used the intended Snap Store configuration. | |
| #1984 tests: update store tests user | snapcraft | merged | Merged PR #1984 (3c313dab1), updating the Store test account, removing two obsolete tests, and revising related test data, documentation, and warnings. | |
| #5370 test: fix store tests | snapcraft | closed | Store-test fixes were superseded by merged #5954, updating credentials and configuration after secret re-provisioning in commit 0be1e384d. | |
| #1460 fix(tests): make store spread tests less flaky | charmcraft | merged | Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429. | |
| #956 tests: idempotent store installs. | snapcraft | merged | PR #956 by sergiusens added idempotent store-install tests (3 files, +10 lines), approved and merged into master as commit d1ad16636. | |
| #1538 tests: update the store failure tests | snapcraft | merged | Merged in #1538 via commit 0a9284cee, updating store-failure tests for autopkgtest reporting, exit-code-2 exceptions, and fake-store execution. | |
| #1133 tests: fix the test that was modifying the environment variables | snapcraft | merged | Merged PR #1133 (commit c0b0f9752), fixing a test that leaked PATH/environment-variable changes and guarding against an empty PATH. |