tests: fix the TEST_STORE environment variable
Metadata
Current evaluation
Merged a fix for the TEST_STORE environment variable. The change prevents skip decorators from running before test setup, resolving unexpected behavior. Approved by three reviewers and squashed prior to merge.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
The environment variable is passed to the containers as ''. The setup of integration tests takes care of translating that to 'fake', but some tests are calling the skip before the setup, so weird things happen.
This is a patch for now. The right solution is to not skip any tests, which is almost always doable.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the TEST_STORE environment variable. The change prevents skip decorators from running before test setup, resolving unexpected behavior. Approved by three reviewers and squashed prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the TEST_STORE environment variable. The patch prevents skip decorators from triggering before setup translates the empty variable to 'fake'. The branch was squashed and merged after reviewer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for TEST_STORE environment variable handling in tests. Replaced premature skip decorators with is_store_fake method calls to prevent early skipping before integration setup. Squashed and merged after maintainer review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #802 Add the TEST_STORE environment variable to the travis script | snapcraft | merged | Merged a Travis CI configuration update adding the TEST_STORE environment variable. Approved by a reviewer, the change ensures the Docker testing environment uses correct test switches and addresses LP #1623645. | |
| #1133 tests: fix the test that was modifying the environment variables | snapcraft | merged | Merged a fix for a test modifying environment variables. Adds an assertion to fail when PATH is empty and uses os.environ instead of grep. Approved by two reviewers, resolves LP #1663396, and applies +3/-2 lines. | |
| #2903 tests: fix status test for staging store | snapcraft | merged | Merged into master after approval and passing CI. The change corrected the staging store status test with a five-line update across one file, resulting in negligible coverage impact. |