← Back to issue list

cleanbuild: don't copy cache into container.

View original Github issue

Metadata

Project
snapcraft
Number
#1216
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1216 as fb38f11e2, stopping cleanbuild from copying build caches into containers; local and remote behavior was verified.

Resolution: closed resolved

Reason: PR #1216 was merged as commit fb38f11e2, removing cleanbuild's cache-copy logic. @popey confirmed that both local and remote cleanbuilds no longer copied the cache.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The cache copy logic needs some more design. Currently it copies in the cache regardless of the target. We need to be smart and only copy the matching hashes. It also needs to weigh in non local remotes and provide user visible feedback in the case where the cache is copied to a non local remote. LP: #1669730 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1216 as fb38f11e2, stopping cleanbuild from copying build caches into containers; local and remote behavior was verified.
stealth/space-bunny-alpha — closed resolved Merged PR #1216 as fb38f11e2, stopping cleanbuild from copying the build cache into containers. @popey verified correct local and remote behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #1216 (fb38f11e2) to stop cleanbuild from copying the build cache into LXD containers, including remote targets.
stealth/space-bunny-alpha — closed resolved Merged #1216, removing cache copying into cleanbuild containers to avoid unnecessary data transfer.
qwen/qwen3.6-35b-a3b — — Merged a fix that stops copying build cache into containers during cleanbuild. Approved after local and remote testing verified correct behavior, eliminating unnecessary data transfer and streamlining the cleanbuild process.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing cleanbuild from copying the cache into containers or non-local remotes. Addresses LP #1669730 by stopping unconditional cache transfers, verified through local and remote testing.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#458 Fix cleanbuild command snapcraft merged Merged PR #458 as commit f78b1e3a3, correcting Cleanbuilder constructor arguments so cleanbuild container construction succeeds; affected tests were updated.
72%
#1372 cli: Containerbuild clean snapcraft merged Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1.
70%