cli: Containerbuild clean
Metadata
Current evaluation
Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1.
Resolution: closed resolved
Reason: PR #1372 was approved and merged. It added regression coverage and corrected argument passing so clean fully cleans the project when container builds are enabled.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add a unit test (and fix) for `SNAPCRAFT_CONTAINER_BUILDS=1 clean`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Despite reviewer testing issues and a separately reported bug, the PR was accepted and merged as-is. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1746381 snapcraft cleanbuild shouldn't always delete container at end | snapcraft (launchpad) | closed | No fix was made: maintainers confirmed cleanbuild containers were disposable, recommended SNAPCRAFT_CONTAINER_BUILDS, and left the request for default failure shells unimplemented. | |
| #1727445 Container destroyed on snapcraft clean -s pull | snapcraft (launchpad) | closed | Fixed by snapcraft PR #1655, which corrected clean-step handling so cleaning the pull step no longer unnecessarily destroys the build container. | |
| #1570706 Snapcraft cleanbuild command doesn't work | snapcraft (launchpad) | closed | Fixed by merged canonical/snapcraft PR #458 (f78b1e3a3), which corrected Cleanbuilder constructor arguments so snapcraft cleanbuild could initialize its container. | |
| #1737 cli: pass remote from container_config to clean method | snapcraft | merged | Merged PR #1737 (commit f7bd699f8): `snapcraft clean` now passes the remote from container_config to the Cleanbuilder, so SNAPCRAFT_CONTAINER_BUILDS=<remote> deletes the container on that remote instead of a local one. Companion fix for refresh followed in #1739. | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379) | |
| #1816042 snapcraft cleanbuild fails if container isn't fully ready | snapcraft (launchpad) | closed | Closed as obsolete: @sergiusens said cleanbuild was no longer supported because normal builds now transparently provide clean builds. | |
| #1734145 snapcraft clean <part-name> destroys everything when using containers | snapcraft (launchpad) | closed | Fixed targeted container cleanup: `snapcraft clean <part>` no longer deletes the LXD container while other parts remain; merged in #1762 (dbce9a058). | |
| #458 Fix cleanbuild command | snapcraft | merged | Merged PR #458 as commit f78b1e3a3, correcting Cleanbuilder constructor arguments so cleanbuild container construction succeeds; affected tests were updated. | |
| #1216 cleanbuild: don't copy cache into container. | snapcraft | merged | Merged #1216 as fb38f11e2, stopping cleanbuild from copying build caches into containers; local and remote behavior was verified. |