cli: Containerbuild clean
Metadata
Current evaluation
Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked.
Suggested action: —
No scores available.
Issue body
Add a unit test (and fix) for `SNAPCRAFT_CONTAINER_BUILDS=1 clean`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Despite reviewer testing issues and a separately reported bug, the PR was accepted and merged as-is. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a unit test and fix for SNAPCRAFT_CONTAINER_BUILDS=1 clean. Changes only modified argument passing. Testing was initially blocked by an unrelated container startup bug reported separately. The PR was accepted and merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1587 lifecycle: clean after deleting container | snapcraft | merged | Merged after addressing reviewer feedback on logic placement. Fixes snapcraft clean not cleaning up after container builds by moving cleanup logic into the container's clean() method. Branch rebased against master and CI passed. | |
| #1737 cli: pass remote from container_config to clean method | snapcraft | merged | Merged a fix ensuring snapcraft clean correctly targets remote containers when SNAPCRAFT_CONTAINER_BUILDS specifies a remote. The change passes the remote configuration to the clean method. Approved after testing and minor discussion on variable naming. | |
| #458 Fix cleanbuild command | snapcraft | merged | Merged fix for the cleanbuild command where incorrect constructor arguments from outside processor rework broke container construction. The author updated unit and static tests per reviewer feedback, after which the pull request was approved and merged. | |
| #1230 lxd: refactor Cleanbuilder into Containerbuild and add Project. | snapcraft | merged | Merged. Refactored Cleanbuilder into a Containerbuild base class and introduced a Project class to manage persistent LXD containers for snap builds. Approved after code review and test fixes. | |
| #3680 commands, parts: add clean command | snapcraft | merged | Added a clean command to remove parts and their build instances when no parts are specified, excluding destructive or managed modes. Merged after approval, passing CI, and rebasing onto snapcraft/7.0. | |
| #2245 docker: support for testing snapcraft in proposed | snapcraft | merged | Merged additions for a xenial-proposed snapcraft test Dockerfile and cleanup of the standard Dockerfile. Changes received approval, passed CI checks, and were validated through successful container execution. | |
| #2179 cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated | snapcraft | merged | Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message. | |
| #2442 cli: enable cleaning of parts | snapcraft | merged | Merged PR restoring snapcraft clean <part-name> functionality for build providers. Reviewers noted edge cases with dependent parts and suggested future improvements for VM-level cleanup, but the feature was successfully integrated. | |
| #1816042 snapcraft cleanbuild fails if container isn't fully ready | snapcraft (launchpad) | closed | The issue describing snapcraft cleanbuild failures when the container is not fully ready was closed. | |
| #1571 Make sure we don't try to include an empty set | snapcraft | merged | Merged a fix preventing snapcraft cleanbuild crashes when parts are null outside the container. The patch adds a guard to skip empty sets. Reviewers suggested lazy loading improvements but approved the change. |