← Back to issue list

Fix cleanbuild command

View original Github issue

Metadata

Project
snapcraft
Number
#458
Type
pull request
State
merged
Author
morphis
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #458 as commit f78b1e3a3, correcting Cleanbuilder constructor arguments so cleanbuild container construction succeeds; affected tests were updated.

Resolution: closed resolved

Reason: PR #458 was merged. Commit f78b1e3a3 fixes Cleanbuilder argument handling and updates the affected tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Due to rework on the outside processor the Cleanbuilder was left not working as the arguments for the constructor where passed incorrect and therefor the container construction failed. LP: #1570706

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #458 as commit f78b1e3a3, correcting Cleanbuilder constructor arguments so cleanbuild container construction succeeds; affected tests were updated.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#458 as f78b1e3a3, fixing cleanbuild container construction by passing Cleanbuilder constructor arguments correctly and updating affected tests.
qwen/qwen3.6-35b-a3b — — Merged fix for the cleanbuild command where incorrect constructor arguments from outside processor rework broke container construction. The author updated unit and static tests per reviewer feedback, after which the pull request was approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for the cleanbuild command where incorrect constructor arguments broke container construction after an outside processor rework. Author updated unit and static tests, reviewer approved, and the pull request was merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2775 remote-build: add clean flag snapcraft closed Closed without merging --clean; tests were split into merged PR #2785, while cleanup was deferred to clean-command integration associated with #2678.
73%
#1216 cleanbuild: don't copy cache into container. snapcraft merged Merged #1216 as fb38f11e2, stopping cleanbuild from copying build caches into containers; local and remote behavior was verified.
72%
#1372 cli: Containerbuild clean snapcraft merged Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1.
71%