← Back to issue list

kernel plugin: check_config(): improve the messaging for some CONFIG_* option

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1689564
Type
issue
State
closed
Author
~p-pisati
Labels
—
Created
Updated
Closed

Current evaluation

Messaging-only change to kernel plugin check_config() landed via GitHub PR snapcore/snapcraft#1303, merged as commit 05c94178; maintainer sergiusens linked the PR and closed LP #1689564.

Resolution: closed resolved

Reason: Commit 05c941787 ("kernel plugin: slightly improve the messaging of check_config() (#1303)") merged into snapcraft, adding kernel-version qualifiers to CONFIG_* error messages; the issue was closed after sergiusens linked the merged PR, with no functional change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Slightly improve the messaging of the check_config() function, by specifying if a kernel option applies only to a certain kernel version: ... CONFIG_CC_STACKPROTECTOR_STRONG (4.1.x and later versions only) ... CONFIG_DEVPTS_MULTIPLE_INSTANCES (4.8.x and earlier versions only) ... No functional changes were introduced in this diff, just the messaging text.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Messaging-only change to kernel plugin check_config() landed via GitHub PR snapcore/snapcraft#1303, merged as commit 05c94178; maintainer sergiusens linked the PR and closed LP #1689564.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1303 via commit 05c941787, improving kernel check_config() messages with applicable kernel versions and no functional changes.
stealth/space-bunny-alpha — closed resolved Implemented in merged PR canonical/snapcraft#1303 (commit 05c941787): check_config() messages now state applicable Linux kernel versions for affected CONFIG_* options.
qwen/qwen3.6-35b-a3b — — Closed after incorporating messaging improvements for CONFIG options to indicate kernel version applicability. No functional changes were introduced.
qwen/qwen3.6-35b-a3b — — Updated check_config() messaging to specify kernel version constraints for CONFIG_* options. The non-functional text improvement was merged.
qwen/qwen3.6-35b-a3b — — Merged a non-functional update to the kernel plugin's check_config() function. The change clarifies version applicability for specific CONFIG_* options in user-facing messages.
qwen3.6-35b-a3b-mtp-q6 — — Closed after the check_config() messaging was updated to specify applicable kernel versions for specific CONFIG_* options. No functional changes were introduced.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#1303 (confidence 98%)

    Merged PR by piso77 that reworded check_config() messages; commit 05c941787 references LP: #1689564

  • Related To: canonical/snapcraft#1223 (confidence 70%)

    Prior commit fda091f50 introduced kernel config verification, whose messages this issue improved

Related issues

Issue Project State Summary Similarity
#1303 kernel plugin: slightly improve the messaging of check_config() snapcraft merged Merged as 05c941787: PR #1303 by piso77 reworded kernel plugin check_config() error messages to state which kernel versions each CONFIG option applies to (LP: #1689564). Message-only, no functional change.
89%
#1786190 kernel plugin: install .config as config-$kernelversion snapcraft (launchpad) closed Fixed by merged canonical/snapcraft#2207 (commit 3b12e9c80): the kernel plugin now installs the build .config as config-$kernelversion.
74%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged kernel-plugin checks that parse .config and initrd module lists, reporting missing mandatory options or boot-required code; landed in commit fda091f50.
74%
#2207 kernel plugin: install .config as config-$kernelversion snapcraft merged Merged PR #2207 (commit 3b12e9c80) by piso77 makes the kernel plugin install the build .config as config-$kernelversion in the kernel snap root, fixing LP1786190.
73%
#1219 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft closed PR closed unmerged after changes were requested (3 open review comments). The same kconfigflavour-based Ubuntu config assembly landed later via snapcraft#1285 (commit bc553a1c6), closing LP #1675454.
71%
#1691116 kernel: config check: remove DMIID option snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1319, commit 1dc35f17e ("kernel plugin: do not warn about DMIID in config check"). The kernel plugin stopped warning when CONFIG_DMIID is absent, since non-EFI targets like armhf lack it. Maintainer closed the LP bug pointing at that PR.
71%