← Back to issue list

nodejs plugin: add support for yarn.

View original Github issue

Metadata

Project
snapcraft
Number
#1245
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged Yarn support for Snapcraft's Node.js plugin in PR #1245 (commit 824a8ba79); the Yarn build test passed despite a Travis timeout.

Resolution: closed resolved

Reason: PR #1245 was merged and landed as commit 824a8ba79. The maintainer reported that the Yarn-specific build test passed; the remaining issue was a Travis timeout rather than a code failure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1639837

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged Yarn support for Snapcraft's Node.js plugin in PR #1245 (commit 824a8ba79); the Yarn build test passed despite a Travis timeout.
stealth/space-bunny-alpha — closed resolved PR #1245 merged (commit 824a8ba79), adding Yarn support to Snapcraft's Node.js plugin for LP bug #1639837, satisfying yarn-based tests locally despite a Travis timeout.
stealth/space-bunny-alpha — closed resolved Merged #1245 in commit 824a8ba79, adding Yarn support to the Node.js plugin; the Yarn build test passed locally despite a Travis timeout.
stealth/space-bunny-alpha — closed resolved PR #1245 added Yarn support to Snapcraft’s Node.js plugin, passing local tests and merging despite a Travis timeout.
qwen/qwen3.6-35b-a3b — — Added yarn support to the nodejs plugin. Approved by one reviewer, local tests passed, and the change was merged despite a Travis CI timeout.
qwen3.6-35b-a3b-mtp-q6 — — Added yarn support to the nodejs plugin. A failing yarn build test was fixed, and the changes were merged despite a Travis CI timeout.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1639837 (confidence 99%)

    Launchpad bug #1639837 tracked the missing Yarn support and was resolved by the implementation in PR #1245.

Related issues

Issue Project State Summary Similarity
#1639837 Missing yarn plugin snapcraft (launchpad) closed Yarn support was added to the nodejs plugin rather than a standalone yarn plugin. PR canonical/snapcraft#1245 ('nodejs plugin: add support for yarn.') merged as commit 824a8ba79; issue closed 2017-04-08.
84%
#936 nodejs plugin: install during pull to support npm run snapcraft merged Merged in snapcraft#936 (commit 0497daaac), installing Node.js dependencies during pull so npm run commands can access them.
74%
#1524 node plugin: record the yarn.lock file snapcraft merged Merged in snapcraft#1524 via commit 4055b4f15, adding yarn.lock recording to the Node.js plugin as part of snapcraft#1453.
70%