← Back to issue list

kernel plugin: slightly improve the messaging of check_config()

View original Github issue

Metadata

Project
snapcraft
Number
#1303
Type
pull request
State
merged
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.

Suggested action: —

No scores available.

Issue body

Slightly improve the messaging of check_config(), by specifying if a kernel option applies only to a certain kernel version: ... CONFIG_CC_STACKPROTECTOR_STRONG (4.1.x and later versions only) ... CONFIG_DEVPTS_MULTIPLE_INSTANCES (4.8.x and earlier versions only) ... No functional changes were introduced in this diff, just the messaging text. Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1689564

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updated the kernel plugin's check_config() messaging to specify applicable kernel versions for configuration options. No functional changes were introduced. The change achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updated the kernel plugin check_config() messaging to specify applicable kernel versions for CONFIG options. This non-functional text change improves clarity. Codecov confirmed 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1689564 kernel plugin: check_config(): improve the messaging for some CONFIG_* option snapcraft (launchpad) closed Updated check_config() messaging to specify kernel version constraints for CONFIG_* options. The non-functional text improvement was merged.
93%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged implementation of check_config() and check_initrd() for the kernel plugin. The update parses .config and initrd files to verify mandatory kernel options and boot code are present. Minor test coverage decrease was accepted.
81%
#4081 Kernel plugin improvements 1 snapcraft merged Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines.
73%
#3998 Kernel plugin: multiple fixes snapcraft merged Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
73%
#1319 kernel plugin: config check: remove DMIID option snapcraft merged Merged removal of the DMIID config check in the kernel plugin. The check triggered false warnings on non-EFI architectures like armhf. Approved by one reviewer with no coverage impact.
73%
#1115 kernel plugin: fix kernel snap layout snapcraft merged Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification.
71%