← Back to issue list

kernel plugin: slightly improve the messaging of check_config()

View original Github issue

Metadata

Project
snapcraft
Number
#1303
Type
pull request
State
merged
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 05c941787: PR #1303 by piso77 reworded kernel plugin check_config() error messages to state which kernel versions each CONFIG option applies to (LP: #1689564). Message-only, no functional change.

Resolution: closed resolved

Reason: PR #1303 was approved and merged into snapcraft as commit 05c941787 ("kernel plugin: slightly improve the messaging of check_config() (#1303)"). The diff (+6/-1) only appends version applicability notes to CONFIG_* error strings such as CONFIG_CC_STACKPROTECTOR_STRONG and CONFIG_DEVPTS_MULTIPLE_INSTANCES.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Slightly improve the messaging of check_config(), by specifying if a kernel option applies only to a certain kernel version: ... CONFIG_CC_STACKPROTECTOR_STRONG (4.1.x and later versions only) ... CONFIG_DEVPTS_MULTIPLE_INSTANCES (4.8.x and earlier versions only) ... No functional changes were introduced in this diff, just the messaging text. Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1689564

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 05c941787: PR #1303 by piso77 reworded kernel plugin check_config() error messages to state which kernel versions each CONFIG option applies to (LP: #1689564). Message-only, no functional change.
stealth/space-bunny-alpha — closed resolved Merged in #1303, commit 05c941787: kernel plugin check_config() messages now identify applicable kernel versions, with no functional changes.
qwen/qwen3.6-35b-a3b — — Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updated the kernel plugin's check_config() messaging to specify applicable kernel versions for configuration options. No functional changes were introduced. The change achieved 100% diff coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1281 (confidence 15%)

    LP: #1689564 references the broader kernel-snaps/kernel-snaps build work that this messaging clarification accompanies; not a code dependency.

Related issues

Issue Project State Summary Similarity
#1689564 kernel plugin: check_config(): improve the messaging for some CONFIG_* option snapcraft (launchpad) closed Messaging-only change to kernel plugin check_config() landed via GitHub PR snapcore/snapcraft#1303, merged as commit 05c94178; maintainer sergiusens linked the PR and closed LP #1689564.
89%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged kernel-plugin checks that parse .config and initrd module lists, reporting missing mandatory options or boot-required code; landed in commit fda091f50.
76%
#2207 kernel plugin: install .config as config-$kernelversion snapcraft merged Merged PR #2207 (commit 3b12e9c80) by piso77 makes the kernel plugin install the build .config as config-$kernelversion in the kernel snap root, fixing LP1786190.
72%