← Back to issue list

rosdep: add support for multiple dependency types

View original Github issue

Metadata

Project
snapcraft
Number
#1479
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1479 (commit 4b2f86d76) added multi-type rosdep parsing and adapted Catkin; pip dependency installation remained follow-up work.

Resolution: closed resolved

Reason: PR #1479 was approved and merged as commit 4b2f86d76, implementing its scoped groundwork for dependency-type-aware rosdep resolution.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR makes progress on #1444 and LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036) by adding the ability for rosdep to parse multiple dependency types. It also updates the catkin plugin to support the new API, but it still only supports debs right now (it'll raise an exception if the dependency type is anything else). This is paving the way for support of pip dependencies coming from rosdep. Actually supporting this will require some experimentation, and of course, a design proposal.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1479 (commit 4b2f86d76) added multi-type rosdep parsing and adapted Catkin; pip dependency installation remained follow-up work.
stealth/space-bunny-alpha — closed resolved Merged as PR #1479 (commit 4b2f86d76), adding rosdep parsing for multiple dependency types and adapting Catkin; pip support was left for follow-up work.
qwen/qwen3.6-35b-a3b — — Merged to add rosdep support for parsing multiple dependency types. The catkin plugin was updated to use the new API, currently limited to debs, laying groundwork for future pip dependency integration. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enables rosdep to parse multiple dependency types and updates the catkin plugin to handle the new API, currently limited to debs. Lays groundwork for future pip dependency support.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1444 (confidence 100%)

    The PR explicitly advanced the Catkin pip-dependency support tracked by this issue.

  • Related To: snapcraft#1581 (confidence 99%)

    Later merged as commit 186ae7f91, adding the pip-based rosdep support left for follow-up.

Related issues

Issue Project State Summary Similarity
#1581 catkin plugin: support rosdep pip dependencies snapcraft merged Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
81%
#1444 catkin pip support snapcraft closed Catkin gained pip-based rosdep dependency support via merged PR #1581 (commit 186ae7f91), following groundwork in #1479 and #1540.
76%
#163 Catkin plugin: use rosdep for dependency resolution snapcraft merged Merged in PR #163 (commit 87b2e24f6), replacing manual Catkin package.xml dependency parsing with rosdep; PR #183 backported the change to Snapcraft 1.x.
73%
#331 Catkin plugin: Handle rosdep empty and multiple dependencies. snapcraft merged PR #331 merged into snapcraft master as commit 1c1119ce3 (merge e3a2b9d03). It refactored the Catkin plugin's rosdep dependency resolution to handle empty output and multiple packages per line, fixing LP bugs #1548406 and #1548404.
71%