catkin plugin: only append PYTHONPATH if set
Metadata
Current evaluation
Merged fix for the Catkin plugin that only appends PYTHONPATH when set, preventing empty segments from resolving to the current directory. Added an environment test to verify the fix. Approved and merged.
Suggested action: —
No scores available.
Issue body
This PR fixes LP: [#1714333](https://bugs.launchpad.net/snapcraft/+bug/1714333) by only including the original PYTHONPATH if it's actually set. Otherwise, Python interprets empty PYTHONPATH segments as the current working directory, which in the case of the Catkin plugin is not desired.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for the Catkin plugin that only appends PYTHONPATH when set, preventing empty segments from resolving to the current directory. Added an environment test to verify the fix. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the catkin plugin that conditionally appends PYTHONPATH only when set, preventing Python from treating empty segments as the current working directory. Adds an integration test verifying no empty path segments remain. Resolves Launchpad bug #1714333. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the Catkin plugin to only append PYTHONPATH when set, preventing empty segments from resolving to the current directory. Adds an integration test verifying environment handling. Fixes LP #1714333. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #324 catkin plugin: do not overwrite the PYTHONPATH | snapcraft | merged | Merged a fix for the catkin plugin that preserves the PYTHONPATH instead of overwriting it. This resolves a ROS test failure and LP: #1544790 by retaining paths set by setup.sh. Approved and merged by maintainers. | |
| #1714333 Catkin plugin: empty segment added to PYTHONPATH | snapcraft (launchpad) | closed | The Catkin plugin incorrectly added an empty PYTHONPATH segment when unset, breaking snap confinement. Closed without comments or a tracked fix, likely abandoned or resolved in a later release. | |
| #1354 catkin plugin: fix pythonpath for catkin_find | snapcraft | closed | Closed and abandoned. The author clarified the fix only resolved a highly specific local setup issue and was no longer relevant. The underlying problem persisted, prompting further troubleshooting on the forum instead of merging the changes. | |
| #1526 catkin plugin: don't assume catkin is in underlay | snapcraft | merged | Merged fix updating the catkin plugin to use its isolated installation instead of assuming catkin exists in the underlay. Resolves Launchpad bug #1696014. Includes reviewer-requested test naming updates. Approved and merged. |