← Back to issue list

catkin plugin: do not overwrite the PYTHONPATH

View original Github issue

Metadata

Project
snapcraft
Number
#324
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for the catkin plugin that preserves the PYTHONPATH instead of overwriting it. This resolves a ROS test failure and LP: #1544790 by retaining paths set by setup.sh. Approved and merged by maintainers.

Suggested action:

No scores available.

Issue body

LP: #1544790

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for the catkin plugin that preserves the PYTHONPATH instead of overwriting it. This resolves a ROS test failure and LP: #1544790 by retaining paths set by setup.sh. Approved and merged by maintainers.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for LP #1544790 that stops the catkin plugin from overwriting PYTHONPATH. Preserving the variable set by setup.sh resolves the ROS test failure and related bug.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the catkin plugin that preserves the PYTHONPATH set by setup.sh instead of overwriting it, resolving a bug that caused ROS test failures.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1522 catkin plugin: only append PYTHONPATH if set snapcraft merged Merged fix for the Catkin plugin that only appends PYTHONPATH when set, preventing empty segments from resolving to the current directory. Added an environment test to verify the fix. Approved and merged.
81%
#1526 catkin plugin: don't assume catkin is in underlay snapcraft merged Merged fix updating the catkin plugin to use its isolated installation instead of assuming catkin exists in the underlay. Resolves Launchpad bug #1696014. Includes reviewer-requested test naming updates. Approved and merged.
75%
#1354 catkin plugin: fix pythonpath for catkin_find snapcraft closed Closed and abandoned. The author clarified the fix only resolved a highly specific local setup issue and was no longer relevant. The underlying problem persisted, prompting further troubleshooting on the forum instead of merging the changes.
74%
#1239 catkin plugin: create completely valid environment snapcraft merged Merged. Updates the Catkin plugin to create a fully valid build-time environment by setting LD_LIBRARY_PATH before sourcing setup.sh and ensuring ROS_HOME is valid. Resolves Launchpad bug #1674487 following maintainer approval.
73%
#1099 catkin plugin: don't pass args to setup.sh. snapcraft merged Merged fix for catkin plugin LP #1660852. Prevents command-line arguments from reaching ROS's setup.sh by saving and clearing them before sourcing, then restoring them before binary execution. Includes updated manual test docs.
73%
#2525 catkin plugin: check stage-snaps for ROS dependencies snapcraft merged Merged to master. Updates the catkin plugin to check stage-snaps for ROS dependencies, preventing redundant fetching by treating them like underlays. Resolves Launchpad bug #1823788. Approved, passed CI, and merged.
71%