← Back to issue list

tests: fix store tests

View original Github issue

Metadata

Project
snapcraft
Number
#5954
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged after approval. Updated store tests with new staging credentials and switched to wheels for automated spread tests. CI passed, with unrelated spread failures noted by the author.

Suggested action:

No scores available.

Issue body

Update to the store tests. My staging store credentials expired and @bepri wasn't able to get the assertion tests working (https://chat.canonical.com/canonical/pl/k3mp6stcxbyw5eojdpz6zs9kih). Since I can't unregister my key named `test-staging-key`, I created new credentials and a new key, `test-staging-key-2` and updated the spread tests. All the store tests have passed, but on different runs. I'm following up on the 504 failure here: https://chat.canonical.com/canonical/pl/o4a9ht1bejn3unogeartcuyg1o Also uses wheels for the automated spread tests (same as https://github.com/canonical/snapcraft/pull/5885). (SNAPCRAFT-1265) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Updated store tests with new staging credentials and switched to wheels for automated spread tests. CI passed, with unrelated spread failures noted by the author.
qwen3.6-35b-a3b-mtp-q6 Merged. Replaced expired staging credentials with new keys and adopted wheels for automated spread tests. All tests passed. Unrelated spread failures were logged separately.
qwen3.6-35b-a3b-mtp-q6 Merged updates to store tests after staging credentials expired. Replaced credentials with new keys and switched automated spread tests to use wheels. All tests passed. Unrelated spread failures were noted for separate tracking.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3090 ci: move staging store tests to spread snapcraft merged Merged into master. The change migrated staging store tests to the spread testing framework, removing 1434 lines across 27 files. Approved by two reviewers, passed CI, and achieved 100% diff coverage prior to integration.
82%
#2903 tests: fix status test for staging store snapcraft merged Merged into master after approval and passing CI. The change corrected the staging store status test with a five-line update across one file, resulting in negligible coverage impact.
80%
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged following approval by two reviewers and successful CI checks. The change resolves issue #1429 by adjusting two files to reduce flakiness in store spread tests, with a net diff of +7/-4 lines.
80%
#3561 spread tests: store metrics against staging (CRAFT-391) snapcraft merged Merged spread tests to store metrics against staging. Approved, passed CI, and added four lines without affecting coverage.
79%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
79%
#1538 tests: update the store failure tests snapcraft merged Merged after approval and passing CI. Updates store failure tests by adjusting autopkgtest scripts to report final errors, sets exception exit codes to 2, and clarifies integration test execution against fake servers.
76%
#5371 test(spread): update store tests snapcraft merged Merged after updating store tests and credentials following a secret re-provisioning that broke existing tests. Adjusted configurations for metrics, base64 credential encoding, and staging store keys to restore test functionality.
76%
#5418 ci: speed up spread test suite snapcraft merged Merged after approval, cutting CI spread test execution from 1h40m to 40m. Changes route slow tests to a dedicated workflow, use build wheels, add store retries, and fix the matter plugin test. Proceeded despite unrelated CI timeouts.
76%
#3089 ci: move staging store tests to spread snapcraft closed Closed without being merged. The pull request to move staging store tests to spread was abandoned, receiving no reviews, CI checks, or comments before closure.
76%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
73%