← Back to issue list

tests: fix store tests

View original Github issue

Metadata

Project
snapcraft
Number
#5954
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885).

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 0be1e384d ("tests: fix store tests (#5954)"), confirmed in the tests/spread/store path history. It replaced the expired staging key with a new key name test-staging-key-2 in 3 files (+3/-3), so the store spread tests passed; the remaining spread failures were noted as unrelated (core26/lxd).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update to the store tests. My staging store credentials expired and @bepri wasn't able to get the assertion tests working (https://chat.canonical.com/canonical/pl/k3mp6stcxbyw5eojdpz6zs9kih). Since I can't unregister my key named `test-staging-key`, I created new credentials and a new key, `test-staging-key-2` and updated the spread tests. All the store tests have passed, but on different runs. I'm following up on the 504 failure here: https://chat.canonical.com/canonical/pl/o4a9ht1bejn3unogeartcuyg1o Also uses wheels for the automated spread tests (same as https://github.com/canonical/snapcraft/pull/5885). (SNAPCRAFT-1265) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885).
stealth/space-bunny-alpha — closed resolved Merged in #5954 (commit 0be1e384d): refreshed store spread tests with new staging credentials/key and wheel-based automated tests.
qwen/qwen3.6-35b-a3b — — Merged after approval. Updated store tests with new staging credentials and switched to wheels for automated spread tests. CI passed, with unrelated spread failures noted by the author.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced expired staging credentials with new keys and adopted wheels for automated spread tests. All tests passed. Unrelated spread failures were logged separately.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5885 (confidence 85%)

    PR body states the wheel-based automated spread test setup is the same approach already merged in #5885.

  • Related To: canonical/snapcraft#5371 (confidence 55%)

    Earlier 'test(spread): update store tests' commit 3067b4bac on the same tests/spread/store directory; #5954 is the follow-up fixing those tests after credential expiry.

Related issues

Issue Project State Summary Similarity
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429.
80%
#5370 test: fix store tests snapcraft closed Store-test fixes were superseded by merged #5954, updating credentials and configuration after secret re-provisioning in commit 0be1e384d.
79%
#3089 ci: move staging store tests to spread snapcraft closed Superseded by merged PR #3090, which moved staging store tests to Spread in commit 3a037fb11.
78%
#2903 tests: fix status test for staging store snapcraft merged Merged PR #2903 as commit 0f0492482, correcting the status test for the staging store.
78%
#1223 tests: fix resource spread test charmcraft merged Merged #1223 (commit 35993996), fixing the flaky store-resources spread test and advancing #1193; related store fixes landed in #1226 and #1234.
78%
#3090 ci: move staging store tests to spread snapcraft merged Merged into master in commit 3a037fb11, moving staging store tests from the legacy suite to Spread and removing 1,434 lines across 27 files.
77%
#5371 test(spread): update store tests snapcraft merged Merged #5371 (commits 3067b4bac/6979dd634, CRAFT-4419): adjusted snapcraft store spread tests and CI secrets after re-provisioning, pointing metrics tests at the testing snap, base64-encoding credentials, and using new staging keys.
76%
#1541 tests: fix the TEST_STORE environment variable snapcraft merged Merged in PR #1541 as commit a36d3e053, fixing TEST_STORE handling so tests no longer skip before the empty value is translated to the fake store.
76%
#1984 tests: update store tests user snapcraft merged Merged PR #1984 (3c313dab1), updating the Store test account, removing two obsolete tests, and revising related test data, documentation, and warnings.
75%
#1290 test(spread): clean up store tests charmcraft merged Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292.
75%