Remove LXD container once we've finished a build
Metadata
Current evaluation
Closed unmerged: testing showed cleanbuild already destroyed its LXD containers; the startup failure was fixed separately by merged PR #458 (f78b1e3a3).
Resolution: closed not a bug
Reason: The maintainer closed #459 after testing confirmed that containers were already destroyed, making the cleanup change unnecessary. The related container-start failure was fixed by merged canonical/snapcraft#458 in commit f78b1e3a3.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There is no need to keep a container if we take a different name
each time we run a build anyway. Container construction is fast
and therefor we can just drop the container once we're done with it.
LP: #1570708
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed not a bug | Closed unmerged: testing showed cleanbuild already destroyed its LXD containers; the startup failure was fixed separately by merged PR #458 (f78b1e3a3). | |
| stealth/space-bunny-alpha | — | closed not a bug | PR #459 was closed unmerged: LXD containers were already destroyed; the container-start failure motivating cleanup was fixed by merged PR #458. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Testing confirmed containers are already destroyed, but the proposed cleanup logic fails because containers must be started first, which was previously broken. The approach was deemed unviable. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rejected. Maintainer noted containers are destroyed post-build but must be started first, which was failing. The proposed cleanup logic was insufficient for the current workflow. Acknowledged and thanked. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#458
(confidence 98%)
Merged fix for the container-start failure that motivated #459.
-
Related To:
Launchpad#1570708
(confidence 90%)
Original Launchpad bug linked from the PR description.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1570708 snapcraft should remove lxd container once finished the build | snapcraft (launchpad) | closed | Closed as invalid after PR #459 found cleanbuild already destroyed its LXD containers; a separate argument-passing failure was fixed by #458 (f78b1e3a3). | |
| #1762 lxd: delete container only if parts is empty | snapcraft | merged | Merged PR #1762 (dbce9a058), changing LXD cleanup to delete a build container only after all parts are removed, preserving it for targeted cleans and making repeated cleans safe. | |
| #2529 build providers: idempotent destroy for LXD | snapcraft | merged | Merged PR #2529 made LXD cleanup idempotent, preventing missing-container errors from masking launch failures; landed as commit 1b2905885. | |
| #1587 lifecycle: clean after deleting container | snapcraft | merged | Merged PR #1587 (commit daca4618b): LXD cleanup logic moved into lxd.py's clean() so `snapcraft clean` removes leftover build containers, addressing the forum-reported container-build clean issue. | |
| #578 Make lxd containers ephemeral | snapcraft | merged | Merged via commit 038bf3f05, making LXD build containers ephemeral and fixing Launchpad bug #1577548. Integration coverage was deferred to bug #1593529. | |
| #1456 clean up stale containers | snapcraft | closed | Stale LXD build-container cleanup was implemented in merged PR #1587 (commit daca4618b), moving cleanup into the LXD clean lifecycle. |